Skip to content

Commit

Permalink
Migrate player shelf to Compose (#3239)
Browse files Browse the repository at this point in the history
  • Loading branch information
ashiagr authored Nov 19, 2024
1 parent 70d70cc commit fcab553
Show file tree
Hide file tree
Showing 11 changed files with 601 additions and 590 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
xmlns:app="http://schemas.android.com/apk/res-auto"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:id="@+id/podcast"
android:background="?attr/selectableItemBackground"
android:clipToPadding="false"
android:orientation="vertical"
Expand Down
2 changes: 2 additions & 0 deletions modules/features/player/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ dependencies {
implementation(libs.androidx.preference.ktx)
implementation(libs.androidx.webkit)
implementation(libs.compose.animation)
implementation(libs.compose.livedata)
implementation(libs.compose.material)
implementation(libs.compose.material.icons.core)
implementation(libs.compose.ui)
Expand All @@ -67,6 +68,7 @@ dependencies {
implementation(libs.lifecycle.reactivestreams.ktx)
implementation(libs.lifecycle.runtime.compose)
implementation(libs.lifecycle.viewmodel.compose)
implementation(libs.lottie.compose)
implementation(libs.media3.exoplayer)
implementation(libs.media3.extractor)
implementation(libs.play.cast)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ private val step4 = TourStep(
"More Actions",
"You can now easily access more actions, as well as customise which actions appear in the player menu.",
"Finish",
TourViewTag.ViewId(R.id.playerActions),
TourViewTag.ViewId(R.id.shelfComposeView),
Gravity.TOP,
)
private val tour = listOf(step1, step2, step3, step4)

Large diffs are not rendered by default.

Loading

0 comments on commit fcab553

Please sign in to comment.