Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up listening history search by limiting the number of results #2979

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

geekygecko
Copy link
Member

@geekygecko geekygecko commented Oct 7, 2024

Description

We had a report that searching over a large listening history was very slow. The cause of this was that it could return a large number of results. I have added a limit to the search results query to speed up this.

Testing Instructions

  1. Subscribe to lots of podcasts
  2. Run the following query in the Android Studio window "App Inspection" UPDATE podcast_episodes SET last_playback_interaction_date = 1700000000000
  3. In the app open the Profile tab
  4. Tap on Listening History
  5. Search using a simple term so lots of results are return

✅ Verify the search results load quickly.

Video

Screen.Recording.2024-10-07.at.11.59.29.am.mov

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@geekygecko geekygecko added this to the 7.75 milestone Oct 7, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Oct 7, 2024

1 Error
🚫 PR requires a [Type] label and either a [Area] or [Project] label.

Generated by 🚫 Danger

@geekygecko geekygecko marked this pull request as ready for review October 7, 2024 07:29
@geekygecko geekygecko requested a review from a team as a code owner October 7, 2024 07:29
@geekygecko geekygecko requested review from ashiagr and removed request for a team October 7, 2024 07:29
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 7, 2024

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commit2d4c6f5
Direct Downloadpocketcasts-app-prototype-build-pr2979-2d4c6f5.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commit2d4c6f5
Direct Downloadpocketcasts-automotive-prototype-build-pr2979-2d4c6f5.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commit2d4c6f5
Direct Downloadpocketcasts-wear-prototype-build-pr2979-2d4c6f5.apk

Copy link
Contributor

@ashiagr ashiagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it!

@ashiagr ashiagr enabled auto-merge (squash) October 7, 2024 07:54
@ashiagr ashiagr merged commit 4d00b63 into main Oct 7, 2024
16 checks passed
@ashiagr ashiagr deleted the task/search-history-speed branch October 7, 2024 07:56
@MiSikora MiSikora modified the milestones: 7.75, 7.72 Oct 8, 2024
@pachlava pachlava added the [Type] Enhancement Improve an existing feature. label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Improve an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants