Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update date added podcast display sort order #3192

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented Nov 7, 2024

Description

This PR makes the following changes

  1. Cross-Platform Sorting: The "Sort by" order on Android matches iOS and Web:
  • Name
  • Episode Release Date
  • Date Added
  • Drag and Drop
  1. Date Added Sorting: New podcast subscriptions are added to the top of the list instead of at the bottom

Internal Ref: p1730854048067249-slack-C06EHRAPW12

Testing Instructions

  1. Login with an account with podcasts and folders
  2. Go to the Podcasts tab
  3. Open Sort By options using more menu in the top bar
  4. ✅ Notice that sort options are displayed in the following order
  • Name
  • Episode Release Date
  • Date Added
  • Drag and Drop
  1. Go to Discover tab and follow a podcast
  2. Tap on Podcasts tab and notice that the podcast is added to the top of the list
  3. Go to Discover and follow another podcast
  4. Add this podcast to an existing folder with podcasts
  5. ✅ Notice that the podcast is added to the top of the list in the folder
  6. Sync data from Profile using Refresh now
  7. Install and open Automotive app using the same account
  8. Open Podcasts tab
  9. ✅ Notice that podcasts are shown in the same order as on phone (make sure that the app is synced with latest data)
  10. Install and open Wear app using the same account
  11. Open Podcasts menu
  12. ✅ Notice that podcasts are shown in the same order as on phone (make sure that the app is synced with latest data)

Screenshots or Screencast

sort_order_date_added.webm
Automotive Podcasts Automotive Inside Folder
after_automotive after_automotive_folder
Wear Podcasts Wear Inside Folder
after_wear after_wear_folder

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@ashiagr ashiagr added [Type] Other Issues not covered by other types, such as refactoring and documentation. [Area] Podcasts Tab labels Nov 7, 2024
@ashiagr ashiagr added this to the 7.77 milestone Nov 7, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 7, 2024

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commit03079ac
Direct Downloadpocketcasts-app-prototype-build-pr3192-03079ac.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commit03079ac
Direct Downloadpocketcasts-automotive-prototype-build-pr3192-03079ac.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commit03079ac
Direct Downloadpocketcasts-wear-prototype-build-pr3192-03079ac.apk

@ashiagr ashiagr marked this pull request as ready for review November 7, 2024 11:12
@ashiagr ashiagr requested a review from a team as a code owner November 7, 2024 11:12
@ashiagr ashiagr requested review from geekygecko and removed request for a team November 7, 2024 11:12
@ashiagr ashiagr enabled auto-merge (squash) November 8, 2024 05:47
@ashiagr ashiagr merged commit 96292fd into main Nov 8, 2024
15 of 16 checks passed
@ashiagr ashiagr deleted the task/update-podcast-sort-order branch November 8, 2024 09:41
@pachlava pachlava added [Type] Enhancement Improve an existing feature. and removed [Type] Other Issues not covered by other types, such as refactoring and documentation. labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Area] Podcasts Tab [Type] Enhancement Improve an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants