Use HTML in the podcast description #3249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
|
geekygecko
force-pushed
the
task/html-description
branch
from
6aa2bdf to
438ec19
Compare
geekygecko
force-pushed
the
task/html-description
branch
from
438ec19 to
e448212
Compare
geekygecko
force-pushed
the
task/html-description
branch
2 times, most recently
from
857b097 to
c491c2c
Compare
geekygecko
added
[Type] Enhancement
geekygecko
force-pushed
the
task/html-description
branch
from
2dffe15 to
36d07e1
Compare
mebarbosa
reviewed
Dec 18, 2024
| title = "Use HTML in the podcast description", | ||
| defaultValue = true, | ||
| tier = FeatureTier.Free, | ||
| hasFirebaseRemoteFlag = true, |
There was a problem hiding this comment.
Since you are already setting this with the firebase flag, I am adding this comment just as a reminder to add the toggle in firebase
mebarbosa
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The server now returns a HTML formatted version of the podcast description. The podcast page has been updated to support the HTML.
There is one issue that I haven't been able to resolve. When using HTML in the view, the three dots to show that you can expand doesn't work. I’m not quite sure how to fix it yet so I will leave it for now.
Testing Instructions
Check with the feature flag off
Screenshots
Checklist
./gradlew spotlessApplyto automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xmlI have tested any UI changes...