Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skip forward/back on some remote devices such as wired and wireless headsets #3297

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

splendidbits
Copy link

@splendidbits splendidbits commented Nov 27, 2024

Description

Fixes #3292 (I'm not sure if this is the exact same issue that I experience, but this is more apt https://forums.pocketcasts.com/forums/topic/skip-and-rewind-with-headphone-controls/).

I have always had issues seeking forward and back using my USB C Apple headphones. It seems that some keycodes are different from those devices, and the extended path for these edge-cases do not support seeking forward and back. This also fixes sporadic play-pause issues for me when the app is in a background state.

Testing Instructions

  1. Start playing a podcast with wired USB C headphones (and possibly other remote devices)
  2. Tap hardware play-pause button to play or pause
  3. Double-tap hardware play-pause button to skip forward
  4. Triple-tap hardware play-pause button to skip backwards

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@splendidbits splendidbits requested a review from a team as a code owner November 27, 2024 19:08
@splendidbits splendidbits requested review from mebarbosa and removed request for a team November 27, 2024 19:08
@CLAassistant
Copy link

CLAassistant commented Nov 27, 2024

CLA assistant check
All committers have signed the CLA.

@splendidbits splendidbits changed the title Fix forward-back on some remote devices such as wired and wireless headsets Fix skip forward/back on some remote devices such as wired and wireless headsets Nov 27, 2024
Copy link
Contributor

@mebarbosa mebarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! We were running some regression tests and that worked as expected

@splendidbits
Copy link
Author

@mebarbosa Thanks! Looking forward to it getting merged. I just wanted to let you know that I added one more condition that I have found over the last week, which I suspected needed to be added.

@mebarbosa
Copy link
Contributor

Thanks for working on this @splendidbits ! Could you please, open another PR with the new changes?

@splendidbits
Copy link
Author

splendidbits commented Dec 11, 2024

Thanks for working on this @splendidbits ! Could you please, open another PR with the new changes?

@mebarbosa Sure, but I don't quite understand how the branching strategy works. This PR appears still unmerged. I can't branch off of this one as I have already committed the extra change.

@mebarbosa
Copy link
Contributor

Thanks for working on this @splendidbits ! Could you please, open another PR with the new changes?

@mebarbosa Sure, but I don't quite understand how the branching strategy works. This PR appears still unmerged. I can't branch off of this one as I have already committed the extra change.

@splendidbits No worries. Thanks for updating your PR again! We might be able to do the regression tests for this PR next, due to a limitation with available buds

@mebarbosa mebarbosa requested a review from geekygecko December 13, 2024 17:13
@splendidbits
Copy link
Author

@mebarbosa Let me know if you need a hand with any test cases. I've been testing with the Apple USB C Wired headphones and the Apple 3.5mm to USB C headphone adapter. Eager to get this in!

@mebarbosa
Copy link
Contributor

@mebarbosa Let me know if you need a hand with any test cases. I've been testing with the Apple USB C Wired headphones and the Apple 3.5mm to USB C headphone adapter. Eager to get this in!

Hey @splendidbits 👋🏽 . Thanks for offering to help with the test. I believe @geekygecko is will handle it, but the team currently has limited availability due to the holidays and end-of-year break.

@mebarbosa mebarbosa assigned mebarbosa and geekygecko and unassigned mebarbosa Dec 18, 2024
@geekygecko
Copy link
Member

I believe @geekygecko is will handle it, but the team currently has limited availability due to the holidays and end-of-year break.

@splendidbits Thanks for taking the time to make this change. It worked well for me.

@geekygecko geekygecko added [Type] Bug Not functioning as intended. [Area] Playback Episode playback issue labels Dec 21, 2024
@geekygecko geekygecko added this to the 7.80 milestone Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Area] Playback Episode playback issue [Type] Bug Not functioning as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android Pocketcast 7.77 breaks Pixel Buds Series-A ability to double tap fast forward.
4 participants