-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix skip forward/back on some remote devices such as wired and wireless headsets #3297
base: main
Are you sure you want to change the base?
Conversation
…roid into issue/3292 # Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! We were running some regression tests and that worked as expected
@mebarbosa Thanks! Looking forward to it getting merged. I just wanted to let you know that I added one more condition that I have found over the last week, which I suspected needed to be added. |
Thanks for working on this @splendidbits ! Could you please, open another PR with the new changes? |
@mebarbosa Sure, but I don't quite understand how the branching strategy works. This PR appears still unmerged. I can't branch off of this one as I have already committed the extra change. |
@splendidbits No worries. Thanks for updating your PR again! We might be able to do the regression tests for this PR next, due to a limitation with available buds |
@mebarbosa Let me know if you need a hand with any test cases. I've been testing with the Apple USB C Wired headphones and the Apple 3.5mm to USB C headphone adapter. Eager to get this in! |
Hey @splendidbits 👋🏽 . Thanks for offering to help with the test. I believe @geekygecko is will handle it, but the team currently has limited availability due to the holidays and end-of-year break. |
@splendidbits Thanks for taking the time to make this change. It worked well for me. |
Description
Fixes #3292 (I'm not sure if this is the exact same issue that I experience, but this is more apt https://forums.pocketcasts.com/forums/topic/skip-and-rewind-with-headphone-controls/).
I have always had issues seeking forward and back using my USB C Apple headphones. It seems that some keycodes are different from those devices, and the extended path for these edge-cases do not support seeking forward and back. This also fixes sporadic play-pause issues for me when the app is in a background state.
Testing Instructions
Checklist
./gradlew spotlessApply
to automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xml