[Draft] Fix: Casting not working correctly to Google Devices #3394
+0
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
stop
method inMediaSessionManager.kt
, which stops the episode when this command is received. However, upon reviewing the code, I noticed that this overriddenstop
method is being called only when attempting to cast an episode. It is not being triggered for theApp
,Wear
, orAutomotive
platforms, as suggested by the comments in the stop method. All platforms call thepause
method insteadFixes #3321
Testing Instructions
Screenshots or Screencast
Checklist
./gradlew spotlessApply
to automatically apply formatting/linting)I have considered whether it makes sense to add tests for my changesAll strings that need to be localized are inmodules/services/localization/src/main/res/values/strings.xml
Any jetpack compose components I added or changed are covered by compose previewsI have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.