Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Private Feed Sharing #3395

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

mebarbosa
Copy link
Contributor

@mebarbosa mebarbosa commented Dec 27, 2024

Description

Testing Instructions

  • Note: I open the app with debugProd and used https://pca.st/private/707a8bf0-9abf-013c-74fe-027201e7e97f private feed
  • Ensure you have the FF enabled

Share In Podcast View

  1. Open a private feed
  2. Tap on the share button at the top
  3. ✅ Ensure you can't share it
  4. Play an episode from this private one
  5. Open Now Playing
  6. Tap on Share Button from shelf items list
  7. ✅ Ensure you can't share it
  8. Also, try to share the podcast from overflow menu
  9. ✅ Ensure you can't share it
Screen_recording_20241227_131449.webm

Share from Podcasts Tab

  1. Follow private feed
  2. Follow some public podcasts
  3. Open the Podcasts tab
  4. Tap on the 3 dots at the top to open the menu
  5. Tap on Share Podcasts
  6. ✅ Ensure you don't see the private one in the Select podcasts list
podcasts.webm

Share Public podcasts

  • Smoke test public podcasts and make sure you can share them

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@mebarbosa mebarbosa added [Type] Enhancement Improve an existing feature. [Area] Podcast Page labels Dec 27, 2024
@mebarbosa mebarbosa added this to the 7.80 milestone Dec 27, 2024
@mebarbosa mebarbosa requested a review from a team as a code owner December 27, 2024 16:52
@mebarbosa mebarbosa requested review from geekygecko and removed request for a team December 27, 2024 16:52
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 7.80. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 27, 2024

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commit28fe968
Direct Downloadpocketcasts-app-prototype-build-pr3395-28fe968.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commit28fe968
Direct Downloadpocketcasts-automotive-prototype-build-pr3395-28fe968.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commit28fe968
Direct Downloadpocketcasts-wear-prototype-build-pr3395-28fe968.apk

@@ -39,7 +39,7 @@ class ShareListCreateViewModel @Inject constructor(
init {
viewModelScope.launch {
val podcasts = podcastManager.findPodcastsOrderByTitle()
mutableState.value = mutableState.value.copy(podcasts = podcasts)
mutableState.value = mutableState.value.copy(podcasts = podcasts.filter { it.canShare })
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided to exclude private ones from this list. See: pdeCcb-7Yf-p2#comment-6356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Area] Podcast Page [Type] Enhancement Improve an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants