Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate native Gravatar Quick Editor to change avatar. #2267

Draft
wants to merge 15 commits into
base: trunk
Choose a base branch
from

Conversation

etoledom
Copy link
Contributor

@etoledom etoledom commented Oct 14, 2024

This PR is a demonstration of integrating the native Gravatar Quick Editor, replacing the web-view interface.

The secrets can be shared internally.

CleanShot 2024-12-05 at 09 00 24

To test

  • Add the Gravatar secrets to the (temporal) GravatarSecrets struct shared internally.
  • Go to Profile -> Account -> Change Avatar
  • Authenticate your Gravatar account.
  • Test the integration of Gravatar Quick Editor with Pocket Casts.

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants