Refactor the use of the AutoDownloadStatus enums #2506
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
| 📘 Part of: # |
|:---:|
Fixes #
On this PR we use the enum directly on the model type and avoid the uses of raw value and casting in the codebase. I also found that FMDatabase can support the use of Enum directly on their statements if they are a base type. Ex: Int32, Int, etc..
One of the things that was blocking it was that our base episode protocol was marked as ObjC. I thought there was some reason for the use of
@objc
tag on the protocols, but after removal I didn't get any kind of error.If someone knows the reason why those protocols are marked @objc please comment bellow.
To test
Checklist
CHANGELOG.md
if necessary.