Move podcastShared analytics events #2587
Open
+16
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles the early returns added in #2582 so we don't log a
podcastShared
event when private podcasts are shared.To test
Private Podcast
Enable the
tracksLogging
feature flagOpen the Podcast detail screen for a private podcast
Tap "Share" and verify that only the following event is logged with no
podcast_shared
event:Open the episode detail page
Verify that no event is logged when tapping share
Play an episode from this podcast
Open the player
Tap the "Share" action button in the shelf
Verify that no
podcast_shared
event is loggedPublic Podcast
Checklist
CHANGELOG.md
if necessary.