Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Psalm workflow #7105

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Add Psalm workflow #7105

merged 1 commit into from
Aug 17, 2023

Conversation

merkushin
Copy link
Member

@merkushin merkushin commented Aug 16, 2023

Resolves part of #7094

Proposed Changes

  • Add Psalm workflow.

Testing Instructions

  1. Create a branch from add/psalm-pipeline.
  2. Push it to GitHub and create a PR.
  3. Check Psalm Test check.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • "Needs Documentation" label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues
CleanShot 2023-08-16 at 02 33 05@2x

@merkushin merkushin added this to the 4.16.2 milestone Aug 16, 2023
@merkushin merkushin requested a review from a team August 16, 2023 00:13
@merkushin merkushin self-assigned this Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #7105 (1472cfc) into add/psalm-baseline (43181e8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                  @@
##             add/psalm-baseline    #7105   +/-   ##
=====================================================
  Coverage                 49.35%   49.35%           
  Complexity                10541    10541           
=====================================================
  Files                       575      575           
  Lines                     44513    44513           
  Branches                    402      402           
=====================================================
  Hits                      21968    21968           
  Misses                    22218    22218           
  Partials                    327      327           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43181e8...1472cfc. Read the comment docs.

m1r0
m1r0 previously approved these changes Aug 17, 2023
Copy link
Member

@m1r0 m1r0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from add/psalm-baseline to trunk August 17, 2023 11:50
@merkushin merkushin dismissed m1r0’s stale review August 17, 2023 11:50

The base branch was changed.

@merkushin merkushin merged commit 6b4a964 into trunk Aug 17, 2023
@merkushin merkushin deleted the add/psalm-pipeline branch August 17, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants