-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/bg fetch #1303
Draft
charliescheer
wants to merge
11
commits into
trunk
Choose a base branch
from
feature/bg-fetch
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+149
−1
Draft
Feature/bg fetch #1303
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8595441
Add background refresh using BackgroundTask api
charliescheer eeb1d8e
Updated earliest background refresh to 30 minutes
charliescheer 3ed393f
Updated refresh to simply wakeup SN and let simperium sync
charliescheer 6d08985
Updated background refresh time
charliescheer f8409c0
Moved BG Fetch to its own file
charliescheer 43250c5
Added timeouts for background refresh
charliescheer 8e71635
Removed retain cycle on bg.finishrefresh
charliescheer 3e5b1e1
Updated background refresh as a stored property in app delegate
charliescheer 466e734
Removed finished variable from refresh manager
charliescheer 22a114a
Added a method to cancel pending BG tasks if SN enters the foreground
charliescheer 4442d55
Updated refresh timer method to onSimperiumChange
charliescheer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| import Foundation | ||
| import BackgroundTasks | ||
|
|
||
| class BackgroundRefreshManager: NSObject { | ||
| private var timer: Timer? { | ||
| didSet { | ||
| oldValue?.invalidate() | ||
| } | ||
| } | ||
|
|
||
| private var handler: (()->Void)? | ||
|
|
||
| var finished: Bool = false { | ||
| didSet { | ||
| if finished == true { | ||
| handler?() | ||
| } | ||
| } | ||
| } | ||
|
|
||
| @objc | ||
| func refreshTimer() { | ||
| // If refresh is not running there will be no handler | ||
| guard handler != nil else { | ||
| return | ||
| } | ||
| NSLog("Refresh Timer Called") | ||
| timer = Timer.scheduledTimer(timeInterval: Constants.timerTimeOut, target: self, selector: #selector(finishRefresh), userInfo: nil, repeats: false) | ||
| } | ||
|
|
||
| @objc | ||
| private func finishRefresh() { | ||
| guard let handler = handler else { | ||
| return | ||
| } | ||
| NSLog("Finish Refresh Called") | ||
|
|
||
| handler() | ||
|
|
||
| finished = false | ||
| self.handler = nil | ||
charliescheer marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| } | ||
|
|
||
| @available(iOS 13.0, *) | ||
| extension BackgroundRefreshManager { | ||
| // MARK: - Background Fetch | ||
| // | ||
| @objc | ||
| func registerBackgroundRefreshTask() { | ||
| NSLog("Registered background task with identifier \(Constants.bgTaskIdentifier)") | ||
| BGTaskScheduler.shared.register(forTaskWithIdentifier: Constants.bgTaskIdentifier, using: .main) { task in | ||
| guard let task = task as? BGAppRefreshTask else { | ||
| return | ||
| } | ||
| self.handleAppRefresh(task: task) | ||
| } | ||
| } | ||
|
|
||
| private func handleAppRefresh(task: BGAppRefreshTask) { | ||
| NSLog("Did fire handle app refresh") | ||
| handler = { | ||
| task.setTaskCompleted(success: true) | ||
| } | ||
|
|
||
| task.expirationHandler = { [weak self] in | ||
| self?.finishRefresh() | ||
| } | ||
|
|
||
| NSLog("Background refresh intiated") | ||
| scheduleAppRefresh() | ||
|
|
||
| refreshTimer() | ||
| } | ||
|
|
||
| @objc | ||
| func scheduleAppRefresh() { | ||
| guard BuildConfiguration.current == .debug else { | ||
| return | ||
| } | ||
|
|
||
| NSLog("Background refresh scheduled") | ||
| let request = BGAppRefreshTaskRequest(identifier: Constants.bgTaskIdentifier) | ||
| request.earliestBeginDate = Date(timeIntervalSinceNow: Constants.earliestBeginDate) | ||
| do { | ||
| try BGTaskScheduler.shared.submit(request) | ||
| NSLog("Background refresh submitted") | ||
| } catch { | ||
| print("Couldn't schedule app refersh: \(error)") | ||
| } | ||
| } | ||
| } | ||
|
|
||
|
|
||
| private struct Constants { | ||
| static let earliestBeginDate = TimeInterval(60) //30 minutes | ||
| static let timeOut = TimeInterval(25) | ||
| static let bundleIdentifier = Bundle.main.bundleIdentifier ?? "com.codality.NotationalFlow" | ||
| static let bgTaskIdentifier = bundleIdentifier + ".refresh" | ||
| static let timerTimeOut = TimeInterval(5) | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| import Foundation | ||
| import BackgroundTasks | ||
|
|
||
|
|
||
| // MARK: - Initialization | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to track
finishedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A totally. The finished variable was something I had put in because I was having issues making an instance of the backgroundFetchManager in the app delegate. Was trying to use changing it to trigger ending the refresh, but using the handler instead can serve that same purpose. I have removed the finished var.