-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passkeys: UI interaction feedback and errors #1604
Draft
charliescheer
wants to merge
27
commits into
feature/passkeys
Choose a base branch
from
charlie/1602/passkey-interaction-feedback-and-errors
base: feature/passkeys
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Passkeys: UI interaction feedback and errors #1604
charliescheer
wants to merge
27
commits into
feature/passkeys
from
charlie/1602/passkey-interaction-feedback-and-errors
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge by ensuring it is url safe.
Generated by 🚫 Danger |
You can test the changes in simplenote-ios from this Pull Request by:
|
charliescheer
force-pushed
the
charlie/passkey-implementation
branch
from
July 1, 2024 17:56
7e524e0
to
23ed723
Compare
Base automatically changed from
charlie/passkey-implementation
to
feature/passkeys
July 2, 2024 20:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Soooo... the first PR for implementing passkeys into iOS has some user interaction issues. None of the errors are handled, so if it fails it just does nothing.... and the registration and auth processes happen over time and can be slow, but the UI give no activity indication, and isn't locked in anyway so you can keep poking and clicking all over the place... not great....
So I have fixed that in this PR. Here you will see:
Test
Registration:
Auth:
Review
(Required) Add instructions for reviewers. For example:
Release
(Required) Add a concise statement to
RELEASE-NOTES.txt
if the changes should be included in release notes. Include details about updating the notes in this section. For example:If the changes should not be included in release notes, add a statement to this section. For example: