Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excerpts: add theme #7881

Closed
wants to merge 5 commits into from
Closed

Excerpts: add theme #7881

wants to merge 5 commits into from

Conversation

henriqueiamarino
Copy link
Collaborator

@henriqueiamarino henriqueiamarino commented Jun 20, 2024

Excerpts is a text-only blog theme that trusts post excerpts rather than titles and featured images and has many variations.
Demo site

screenshot

Copy link
Contributor

github-actions bot commented Jun 20, 2024

Preview changes

I've detected changes to the following themes in this PR: Excerpts.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@alaczek
Copy link
Contributor

alaczek commented Aug 29, 2024

I'm seeing a few UX issues with this theme:

  • Site title isn't displayed anywhere, while the nav is used twice in the header.
  • The header is invisible on internal pages, and lacks left/right spacing:
image
  • the info about theme download in the footer doesn't make sense from the customer point of view. While it's true that customers can remove this via the editor, we also know it's quite hard to navigate for inexperienced users. We can keep that info on the demo page, but I recommend removing it from the theme.

  • the footer has a broken block in the editor:

image
  • single posts have a different sidebar content than other templates - was this intentional?
  • sidebar.php has a hard-coded link that won't work, unless customer site happens to have a page with the slug posts: <p class="has-text-align-right has-medium-font-size"><?php echo __('<a href="/posts/">All articles</a> ↘', 'excerpts');?></p>
  • while I understand the choice not to display post titles on the homepage, not including them on single posts feels like a bug.
  • in the post editor the content has no left/right spacing:
image

@MaggieCabrera MaggieCabrera added the Ready to launch Add this label if this is the first PR for a new theme label Sep 3, 2024
@henriqueiamarino
Copy link
Collaborator Author

I committed all the necessary changes and added some diversity to the existing style variations.

Later, I noticed an Excerpts staging site, which may have already been submitted to Dotor. To avoid a naming conflict, I am closing this PR for the benefit of #8067. It was renamed, and it's now Titleless.

@henriqueiamarino henriqueiamarino deleted the add/excerpts branch September 4, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to launch Add this label if this is the first PR for a new theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants