Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrato: fixing after Dotorg review #8058

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Retrato: fixing after Dotorg review #8058

merged 2 commits into from
Sep 5, 2024

Conversation

henriqueiamarino
Copy link
Collaborator

@henriqueiamarino henriqueiamarino commented Sep 3, 2024

Fixing issues mentioned in the Dotorg review process:

  • Added underlines to links;
  • Standardized the image credits.

https://themes.trac.wordpress.org/ticket/187324#comment:3

Copy link
Contributor

github-actions bot commented Sep 3, 2024

Preview changes

I've detected changes to the following themes in this PR: Retrato.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link
Member

@madhusudhand madhusudhand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henriqueiamarino Could you provide link to the dotOrg review feedback?

Also, theme throws following errors. Could you address them?

style.css : Message : missing 'Requires at least' header metadata

You can view complete list of errors by running npm run validate:json retrato.
Note: this script got merged recently. Please run on the changes from latest trunk.

@henriqueiamarino
Copy link
Collaborator Author

Thanks, @madhusudhand. I am still trying to figure out what happened. The theme is working fine, with no errors detected by the Theme Check plugin. I'll add it again.

@henriqueiamarino
Copy link
Collaborator Author

@madhusudhand, I believe, is working now. At least no errors are visible on the preview link.

@henriqueiamarino henriqueiamarino added the Ready to launch Add this label if this is the first PR for a new theme label Sep 4, 2024
Copy link
Contributor

@MaggieCabrera MaggieCabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@henriqueiamarino henriqueiamarino merged commit 1556783 into trunk Sep 5, 2024
2 checks passed
@henriqueiamarino henriqueiamarino deleted the update/retrato branch September 5, 2024 08:40
@henriqueiamarino
Copy link
Collaborator Author

@MaggieCabrera, here's the demo content file.

retrato.WordPress.2024-09-12.xml.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to launch Add this label if this is the first PR for a new theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants