-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retrato: fixing after Dotorg review #8058
Conversation
Preview changesI've detected changes to the following themes in this PR: Retrato. You can preview these changes by following the links below: I will update this comment with the latest preview links as you push more changes to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@henriqueiamarino Could you provide link to the dotOrg review feedback?
Also, theme throws following errors. Could you address them?
style.css : Message : missing 'Requires at least' header metadata
You can view complete list of errors by running npm run validate:json retrato
.
Note: this script got merged recently. Please run on the changes from latest trunk.
Thanks, @madhusudhand. I am still trying to figure out what happened. The theme is working fine, with no errors detected by the Theme Check plugin. I'll add it again. |
@madhusudhand, I believe, is working now. At least no errors are visible on the preview link. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@MaggieCabrera, here's the demo content file. |
Fixing issues mentioned in the Dotorg review process:
https://themes.trac.wordpress.org/ticket/187324#comment:3