Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Assembler outline variation size and style #8489

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

richtabor
Copy link
Contributor

Making the outline button variation the same size as the default. Also removes the brightness effect on the button; was a bit finicky.

Visual

Before After
CleanShot 2024-12-04 at 18 13 11 CleanShot 2024-12-04 at 18 12 03

@richtabor richtabor added the [Type] Bug Something isn't working label Dec 4, 2024
@richtabor richtabor requested a review from alaczek December 4, 2024 23:15
@richtabor richtabor self-assigned this Dec 4, 2024
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Preview changes

I've detected changes to the following themes in this PR: Assembler.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Theme-Check results

assembler: No changes required ✅.


Copy link
Contributor

@MaggieCabrera MaggieCabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richtabor richtabor merged commit 568f993 into trunk Dec 5, 2024
3 checks passed
@richtabor richtabor deleted the fix/assembler-button-tit;e branch December 5, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants