-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LeanCV: fixes issues mentioned on #8517 #8518
Conversation
Preview changesI've detected changes to the following themes in this PR: LeanCV. I will update this comment with the latest preview links as you push more changes to this PR. Note The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions. |
@henriqueiamarino Thanks for the update! I've pushed a change to fix the things that seem overlooked.
-- |
Thanks, @iamtakashi. It's really disturbing how some changes I make vanish from the commits. I am 100% sure I noticed those. I did remove those patterns and added . That's a bummer. Anyway, yes, the default-duotone replacement works only after you activate the theme.json, for instance, after refreshing the Editor. Several ready-to-use duotone presets will work for this one, but we should not abandon the unique default duotone technique entirely on other themes. It's helpful, and eventually, the Editor will be faster at displaying that change. I can add more presets and fix the style variations for this one. It's restrictive for users but probably the faster solution. |
Theme-Check resultsleancv: No changes required ✅. |
Beautiful. Thanks, @henriqueiamarino. I just pushed a change to update the minimum PHP version again. Sorry for being back and forth. It looks like 8.2 will be the minimum PHP version going forward. (more info) |
I'll merge this and bump up the version. The dotorg version should be updated automatically. I'll launch this on dotcom soon, so it'd be great if you could send me the demo content. |
This PR addresses the issues mentioned by @iamtakashi in review #8517.