Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LeanCV: fixes issues mentioned on #8517 #8518

Merged
merged 6 commits into from
Dec 13, 2024
Merged

LeanCV: fixes issues mentioned on #8517 #8518

merged 6 commits into from
Dec 13, 2024

Conversation

henriqueiamarino
Copy link
Collaborator

@henriqueiamarino henriqueiamarino commented Dec 12, 2024

This PR addresses the issues mentioned by @iamtakashi in review #8517.

  • The only solution I found for the duotone issue will impact users, I am aware. But I do think this is better than simply removing duotones, which would impact much more the theme's concept;
  • Mobile menu set;
  • The strong tags were removed;
  • Font size presets adjusted, and numeric font values on theme.json were all turned into presets;
  • Removed unused template parts;
  • Removed unused patterns;
  • Fixed Footer padding;
  • Checked and fixed all the tags. They are all set to the Content block now;
  • Updated readme.txt and style.css for the Version number, Tested Up To, and Requires PHP;
  • Removed tags and set the necessary ones.

Copy link
Contributor

Preview changes

I've detected changes to the following themes in this PR: LeanCV.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@iamtakashi iamtakashi self-requested a review December 12, 2024 14:49
@iamtakashi
Copy link
Contributor

iamtakashi commented Dec 13, 2024

@henriqueiamarino Thanks for the update! I've pushed a change to fix the things that seem overlooked.

  • Removed patterns/hidden-404.php, patterns/portrait.php, and patterns/self.php.
  • Added wide-blocks tag.
  • Changed the version number to 1.0.0 inside the changelog.
  • Changed the minimum PHP version to 7.0 (it was my fault) in the readme.txt and the style.css.
  • Added back the theme tag blog (since the theme description says a blog theme).

--
Now, I noticed the duotoned elements don't change immediately in the editor. (It changes on the front of the site, though) The Professio theme is also suffering from this. You have overcome this issue in AlleyOop and Raconteur. Should we do the same in this theme?
CleanShot 2024-12-13 at 01 41 23

@henriqueiamarino
Copy link
Collaborator Author

henriqueiamarino commented Dec 13, 2024

Thanks, @iamtakashi. It's really disturbing how some changes I make vanish from the commits. I am 100% sure I noticed those. I did remove those patterns and added . That's a bummer. Anyway, yes, the default-duotone replacement works only after you activate the theme.json, for instance, after refreshing the Editor.

Several ready-to-use duotone presets will work for this one, but we should not abandon the unique default duotone technique entirely on other themes. It's helpful, and eventually, the Editor will be faster at displaying that change.

I can add more presets and fix the style variations for this one. It's restrictive for users but probably the faster solution.

Copy link
Contributor

Theme-Check results

leancv: No changes required ✅.


@iamtakashi
Copy link
Contributor

Beautiful. Thanks, @henriqueiamarino.

I just pushed a change to update the minimum PHP version again. Sorry for being back and forth. It looks like 8.2 will be the minimum PHP version going forward. (more info)

@iamtakashi
Copy link
Contributor

I'll merge this and bump up the version. The dotorg version should be updated automatically. I'll launch this on dotcom soon, so it'd be great if you could send me the demo content.

@iamtakashi iamtakashi merged commit bebfbdd into trunk Dec 13, 2024
3 checks passed
@iamtakashi iamtakashi deleted the update/leancv branch December 13, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants