fix(dev-env): disallow running dev-env as root
#2173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a check that dev env commands are not running under the
root
user. Using theroot
user creates numerous issues (e.g., permissions, user mapping, etc), often resulting in broken environments.NB: we may want to improve the wording.
Ref: 198752-z
Pull request checklist
New release checklist
Steps to Test
Check out the PR, build
vip-cli
, and run (this is a Linux version; I am not sure how to do that on a Mac):sudo -E --preserve-env=PATH $(which vip) dev-env ls
The expected result is