Add WpDateTime to parse UTC/GMT time
#454
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They don't get Sendable conformance by default now, because `WpDateTime` uses a reference type internally.
oguzkocer
reviewed
Dec 24, 2024
| // This is an intermediate struct to allow the public `WpDateTime` to be exported as a | ||
| // uniffi Record type. This struct itself is exported as a uniffi Object type. | ||
| #[derive(Debug, Clone, PartialEq, Eq, uniffi::Object)] | ||
| struct GMTDateTime { |
There was a problem hiding this comment.
I don't think we need both WpDateTime & GMTDateTime at the same time since one is just a wrapper for the other. We can use one exported uniffi::Object with an inner type and that should be enough.
oguzkocer
reviewed
Dec 24, 2024
There was a problem hiding this comment.
I had already worked on a similar solution in another branch. I think that solution might be slightly more flexible to cover multiple date formats, but curious to hear what you think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relate to #262.
The new
WpDateTimetype is used on posts. If the solution looks good, I can make further changes to use it on other endpoints.