Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom Javascript files #1808

Closed
1 of 6 tasks
ShootingStarD opened this issue Sep 19, 2024 · 10 comments · Fixed by #2359
Closed
1 of 6 tasks

Allow custom Javascript files #1808

ShootingStarD opened this issue Sep 19, 2024 · 10 comments · Fixed by #2359
Assignees
Labels
💬 Discussion Requires some discussion and decision 🖰 GUI Related to GUI ✨New feature 🟧 Priority: High Must be addressed as soon 🔒 Staff only Can only be assigned to the Taipy R&D team

Comments

@ShootingStarD
Copy link

ShootingStarD commented Sep 19, 2024

Description

Currently we can use the Extension API to import javascript components in a Taipy app. However it could also be useful to import JS files in a taipy project, like Dash can do, for example to add certain animations on the page or other things like that.

I think it would also be good for prototyping before making a real compenent via the Extensions API

Solution Proposed

I imagine that we can add an argument in the GUI constructor so that we can add a list of javascript files that will be loaded in the header of html pages generated by the Taipy App

Impact of Solution

NA

Additional Context

While the feature is not really urgent or anything, I thing it is a good add-on for Taipy to become "as easy to use as streamlit, and as customizable as Dash"

Acceptance Criteria

  • Ensure new code is unit tested, and check code coverage is at least 90%.
  • Create related issue in taipy-doc for documentation and Release Notes.
  • Check if a new demo could be provided based on this, or if legacy demos could be benefit from it.
  • Ensure any change is well documented.

Code of Conduct

  • I have checked the existing issues.
  • I am willing to work on this issue (optional)
@jrobinAV jrobinAV added 🖰 GUI Related to GUI 🆘 Help wanted Open to participation from the community 🟧 Priority: High Must be addressed as soon hacktoberfest hacktoberfest issues hacktoberfest - 200💎💎 Issues rewarded by 200 points hacktoberfest - 100💎 Issues rewarded by 100 points and removed hacktoberfest - 200💎💎 Issues rewarded by 200 points labels Sep 20, 2024
@pravintargaryen
Copy link

Can i take this issue?

@jrobinAV
Copy link
Member

jrobinAV commented Oct 1, 2024

Hello,

Yes sure. I just assigned it to you.

@pravintargaryen
Copy link

thanks

Copy link

quest-bot bot commented Oct 7, 2024

New Quest! image New Quest!

A new Quest has been launched in @Avaiga’s repo.
Merge a PR that solves this issue to loot the Quest and earn your reward.


Some loot has been stashed in this issue to reward the solver!

🗡 Comment @quest-bot embark to check-in for this Quest and start solving the issue. Other solvers will be notified!

⚔️ When you submit a PR, comment @quest-bot loot #1808 to link your PR to this Quest.

Questions? Check out the docs.

@quest-bot quest-bot bot added the ⚔️ Quest Tracks quest-bot quests label Oct 7, 2024
@NILAY1556
Copy link

hey @pravintargaryen are you still working on it nuh !?

@pravintargaryen
Copy link

Yep @NILAY1556

@mitgajera
Copy link

Hello @jrobinAV,
Could you please add me as an assignee?

@pravintargaryen
Copy link

Hi @jrobinAV,

will send a PR today

Copy link
Contributor

This issue has been labelled as "🥶Waiting for contributor" because it has been inactive for more than 14 days. If you would like to continue working on this issue, please add another comment or create a PR that links to this issue. If a PR has already been created which refers to this issue, then you should explicitly mention this issue in the relevant PR. Otherwise, you will be unassigned in 14 days. For more information please refer to the contributing guidelines.

@github-actions github-actions bot added the 🥶Waiting for contributor Issues or PRs waiting for a long time label Oct 31, 2024
Copy link
Contributor

This issue has been unassigned automatically because it has been marked as "🥶Waiting for contributor" for more than 14 days with no activity.

@github-actions github-actions bot removed the 🥶Waiting for contributor Issues or PRs waiting for a long time label Nov 15, 2024
@jrobinAV jrobinAV removed hacktoberfest hacktoberfest issues hacktoberfest - 100💎 Issues rewarded by 100 points ⚔️ Quest Tracks quest-bot quests labels Nov 15, 2024
@jrobinAV jrobinAV added 💬 Discussion Requires some discussion and decision and removed 🆘 Help wanted Open to participation from the community labels Dec 16, 2024
@jrobinAV jrobinAV added the 🔒 Staff only Can only be assigned to the Taipy R&D team label Dec 16, 2024
@namnguyen20999 namnguyen20999 linked a pull request Dec 20, 2024 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💬 Discussion Requires some discussion and decision 🖰 GUI Related to GUI ✨New feature 🟧 Priority: High Must be addressed as soon 🔒 Staff only Can only be assigned to the Taipy R&D team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants