Allow custom Javascript files #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
namnguyen20999
requested review from
dinhlongviolin1,
FabienLelaquais and
FredLL-Avaiga
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
FredLL-Avaiga
requested changes
Dec 20, 2024
FabienLelaquais
previously approved these changes
Dec 23, 2024
FredLL-Avaiga
previously requested changes
Dec 23, 2024
taipy/gui/gui.py
Outdated
| @@ -411,6 +419,32 @@ def __init__( | |||
| for library in libraries: | |||
| Gui.add_library(library) | |||
|
|
|||
| def __load_scripts(self, script_paths: t.Optional[t.Union[str, Path, t.List[t.Union[str, Path]]]]): | |||
| def load_script(path: t.Union[str, Path]): | |||
There was a problem hiding this comment.
what's the point of inner defined function ?
There was a problem hiding this comment.
it was based on Fabien suggestion
There was a problem hiding this comment.
Inner functions don't clobber the namespace. I like that, as long as these functions are not evaluated over and over... which is the case here.
There was a problem hiding this comment.
the code of the inner function is called only once ... what's the point ?
There was a problem hiding this comment.
Oh... that's different.
A function called only once is kind of useless indeed.
Then a comment does the trick, expanding the function where it belongs.
namnguyen20999
force-pushed
the
1808-allow-custom-javascript-files
branch
from
700cc9a to
3bc41b8
Compare
…es' into 1808-allow-custom-javascript-files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Allowing custom javascript file from GUI
Related Tickets & Documents
#1808
Checklist
We encourage you to keep the code coverage percentage at 80% and above.