Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chart extension documentation #2341

Merged
merged 7 commits into from
Dec 19, 2024
Merged

Chart extension documentation #2341

merged 7 commits into from
Dec 19, 2024

Conversation

namnguyen20999
Copy link
Member

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Example for Chart extension

@namnguyen20999 namnguyen20999 self-assigned this Dec 16, 2024
@namnguyen20999 namnguyen20999 added 📄 Documentation Internal or public documentation 🖰 GUI Related to GUI labels Dec 16, 2024
@namnguyen20999 namnguyen20999 changed the title Initial commit for chart extension Chart extension documentation Dec 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19472 16976 87% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: e719b7c by action🐍

FabienLelaquais
FabienLelaquais previously requested changes Dec 17, 2024
View reviewed changes
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
A common source file header would be nice though.

doc/gui/extension/example_library/front-end/src/Dashboard.tsx Show resolved Hide resolved
doc/gui/extension/example_library/front-end/webpack.config.js Show resolved Hide resolved
FabienLelaquais
FabienLelaquais reviewed Dec 18, 2024
View reviewed changes
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

FabienLelaquais
FabienLelaquais requested changes Dec 19, 2024
View reviewed changes
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last try?

doc/gui/extension/dashboard.py Outdated Show resolved Hide resolved
FabienLelaquais
FabienLelaquais approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@namnguyen20999 namnguyen20999 merged commit 5a4b3f8 into develop Dec 19, 2024
126 checks passed
@namnguyen20999 namnguyen20999 deleted the docs/extension_chart branch December 19, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabienLelaquais FabienLelaquais FabienLelaquais approved these changes

@FredLL-Avaiga FredLL-Avaiga Awaiting requested review from FredLL-Avaiga

Assignees

@namnguyen20999 namnguyen20999

Labels
📄 Documentation Internal or public documentation 🖰 GUI Related to GUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@namnguyen20999 @FabienLelaquais