Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Only log the string values of the _ALL_EXPOSED_TYPES when run the _DataNodeConfigChecker #2368

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

trgiangdo
Copy link
Member

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

PR #2296 introduces a failed test, where the error log of the _DataNodeConfigChecker also includes the string for pandas.DataFrame and numpy.array.

This PR updates the _DataNodeConfigChecker to only log the string values of the _ALL_EXPOSED_TYPES

@trgiangdo trgiangdo added 💥Malfunction Addresses an identified problem. Core: Data node labels Dec 25, 2024
@trgiangdo trgiangdo self-assigned this Dec 25, 2024
Copy link
Contributor

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
19502 16989 87% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
taipy/core/config/checkers/_data_node_config_checker.py 98% 🟢
TOTAL 98% 🟢

updated for commit: 4ccf4eb by action🐍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core: Data node 💥Malfunction Addresses an identified problem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant