Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce pipeline.yaml file for CS #1016

Merged
merged 2 commits into from
Dec 21, 2024
Merged

introduce pipeline.yaml file for CS #1016

merged 2 commits into from
Dec 21, 2024

Conversation

geoberle
Copy link
Collaborator

What this PR does

  • remove config.mk
  • and introduce pipeline.yaml instead

adopting pipeline.yaml required different handling for certain vars since functions like ternary are not available there.
for the DB settings, i followed the same approach as for maestro, namely having dedicated preset value override files for the two scenarios.

additonally the operator configmap handling needed touching as well. since b64 encoding is not available the 6 operator role names are now provided via dedicated config.yaml vars. the rest of the information in the configmap is either the same in all environments (and can be defined directly in the configmap itself) or can be determined at runtime (e.g. the actual role resource IDs).

Jira:
Link to demo recording:

Special notes for your reviewer

Signed-off-by: Gerd Oberlechner <[email protected]>
Copy link
Collaborator

@tony-schndr tony-schndr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

Signed-off-by: Gerd Oberlechner <[email protected]>
@geoberle geoberle merged commit e52c88e into main Dec 21, 2024
21 checks passed
@geoberle geoberle deleted the cs-pipeline-file branch December 21, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants