This repository has been archived by the owner on May 7, 2024. It is now read-only.
UserStory30082-Migration-ClassicAlerts #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oZakari
reviewed
Oct 18, 2023
| | extend isUsingClassicAlerts = case(isnull(monitoringSettings), 'Enabled',monitoringSettings.classicAlertSettings.alertsForCriticalOperations) | ||
| | extend isUsingJobsAlerts = case(isnull(monitoringSettings), 'Enabled', monitoringSettings.azureMonitorAlertSettings.alertsForAllJobFailures) | ||
| | where isUsingClassicAlerts == 'Enabled' | ||
| | project recommendationId = "bk-1",name,resourceGroup,location,type,id,isUsingClassicAlerts,isUsingJobsAlerts |
There was a problem hiding this comment.
Hi @Poven795909, looks good overall, just one small change and then we should be able to merge. Could you please adjust the columns returned to only the ones listed here
You could adjust to something like the following as an example: | project recommendationId = "bk-1", name, id, param1=strcat(isUsingClassicAlerts: ", isUsingClassicAlerts), param2=strcat("isUsingJobsAlerts: ", isUsingJobsAlerts)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
UserStory30082-Migration-ClassicAlerts
This PR fixes/adds/changes/removes