Skip to content

Commit

Permalink
Disable shared access key (#93)
Browse files Browse the repository at this point in the history
<!-- Thank you for submitting a Pull Request. Please fill out the
template below.-->
## Overview/Summary

Turn off the ability to use a shared access key on the state file
storage account

## This PR fixes/adds/changes/removes

N/A

### Breaking Changes

None

## Testing Evidence

e2e tests run

## As part of this Pull Request I have

- [x] Checked for duplicate [Pull
Requests](https://github.com/Azure/alz-terraform-accelerator/pulls)
- [x] Associated it with relevant
[issues](https://github.com/Azure/alz-terraform-accelerator/issues), for
tracking and closure.
- [x] Ensured my code/branch is up-to-date with the latest changes in
the `main`
[branch](https://github.com/Azure/alz-terraform-accelerator/tree/main)
- [x] Performed testing and provided evidence.
- [x] Updated relevant and associated documentation.
  • Loading branch information
jaredfholgate authored Jan 23, 2024
1 parent fc9fb5b commit 1951c5d
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ provider "azurerm" {
prevent_deletion_if_contains_resources = false
}
}
storage_use_azuread = true
}

provider "azuredevops" {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ provider "azurerm" {
prevent_deletion_if_contains_resources = false
}
}
storage_use_azuread = true
}

provider "github" {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,5 @@ provider "azurerm" {
prevent_deletion_if_contains_resources = false
}
}
storage_use_azuread = true
}
1 change: 1 addition & 0 deletions bootstrap/modules/azure/storage.tf
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ resource "azurerm_storage_account" "alz" {
account_tier = "Standard"
account_replication_type = "GRS"
allow_nested_items_to_be_public = false
shared_access_key_enabled = false
public_network_access_enabled = local.use_private_networking && !var.allow_storage_access_from_my_ip ? false : true
}

Expand Down

0 comments on commit 1951c5d

Please sign in to comment.