feat: adding Financial Services Landing Zone #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredfholgate
previously approved these changes
Nov 12, 2024
There was a problem hiding this comment.
I am approving given the timescales, since I don't see anything that is a major problem. However, we still have the existing issues resulting from the inclusion of subscription vending here. It won't work with Azure DevOps, GitHub or Local with Remote state.
I have left some comments. It is up to you if you address them though.
...tes/microsoft_cloud_for_industry/financial_services_landing_zone/locals.allowed_locations.tf
Show resolved
Hide resolved
templates/microsoft_cloud_for_industry/financial_services_landing_zone/locals.tf
Show resolved
Hide resolved
templates/microsoft_cloud_for_industry/financial_services_landing_zone/locals.tf
Show resolved
Hide resolved
templates/microsoft_cloud_for_industry/financial_services_landing_zone/locals.tf
Show resolved
Hide resolved
templates/microsoft_cloud_for_industry/financial_services_landing_zone/locals.tf
Show resolved
Hide resolved
templates/microsoft_cloud_for_industry/financial_services_landing_zone/variables.tf
Show resolved
Hide resolved
templates/microsoft_cloud_for_industry/financial_services_landing_zone/variables.tf
Show resolved
Hide resolved
jaredfholgate
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Replace this with a brief description of what this Pull Request fixes, changes, etc.
This PR fixes/adds/changes/removes
Breaking Changes
Testing Evidence
As part of this Pull Request I have
mainbranch