Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: virtual network id not known at plan time #183

Merged
merged 7 commits into from
Nov 27, 2024

Conversation

jaredfholgate
Copy link
Member

@jaredfholgate jaredfholgate commented Nov 26, 2024

Overview/Summary

In some scenarios, the virtual network id is not known at plan time. This is due to the explicit dependency on the resource group module. This PR removes the explicit dependency and creates and implicit dependency instead.

This PR fixes/adds/changes/removes

N/A

Breaking Changes

No significant breaking changes

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@jaredfholgate jaredfholgate self-assigned this Nov 26, 2024
@jaredfholgate jaredfholgate merged commit 3be1d02 into main Nov 27, 2024
4 checks passed
@jaredfholgate jaredfholgate deleted the bug-virtual-network-id-not-known-at-plan-time branch November 27, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants