-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: split service principal for plan and apply #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am merging this as has been tested and required as the basis for the next features |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
As per issue #24. This PR is to add an additional user assigned managed identity and isolate permissions for plan and apply. This PR is being done before some of the others as it is a significant refactor and makes sense to do it prior to layering other changes on top.
This change is driven by community asks for 'best practice' around security. This will be combined with a second issue for required templates to demonstrate how to secure a pipeline. We want this accelerator to be consumed by all customers, including those with tight security needs, so adding these features to enable that.
In the future it could also serve as a generic model for secure pipelines with Terraform if we extract it into module(s).
In summary, the initial implementation had:
This PR moves the model to:
The
.test
template has been updated to include creating a management group and a resource group to prove the read and write permissions work as expected.This PR fixes/adds/changes/removes
Breaking Changes
There are no changes to the interface for users of the PowerShell module, all inputs remain the same. Just the deployed resources change.
Testing Evidence
E2E tests will be run as part of this PR.
Manual testing of:
As part of this Pull Request I have
main
branch