-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: governed pipelines #49
Conversation
Looks good, only thing (slightly pedantic so no worries if too difficult). I wouldn't "." some folders here. I think templates/.ci_cd can be just ci_cd because that folder will never be in the target repo(s), whereas templates/.ci_cd/.github/workflows and templates/.ci_cd/.azuredevops will be so it makes sense there. Secondly, maybe the templates/.templates folder could be named something like pipeline_templates or similar. |
I think I did this more for ordering than anything else and is now redundant since we can explicitly set the target folder / file names. I think I will move the azure devops templates to root and remove the dots as suggested. Incoming... |
Overview/Summary
The PR implements governed templates for plan and apply stages to lock down what can be done with the identities.
Azure DevOps and GitHub have different implementations:
This PR fixes/adds/changes/removes
Breaking Changes
Testing Evidence
Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
As part of this Pull Request I have
main
branch