Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Sentinel and connection string support #6

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Adding Sentinel and connection string support #6

wants to merge 4 commits into from

Conversation

cjb5790
Copy link

@cjb5790 cjb5790 commented Sep 9, 2015

Utilizing the serviceName property within a connection string, the provider will now discover the master Redis instance and use that IP for it's connection. Support has also been added to use the existing connectionString node of the web.config.

Chris Bohatka added 4 commits September 9, 2015 14:29
Added support for Sentinel Configuration
740fa5e 
-Keys off of serviceName in the connectionString
-Rebuilds config after running 'get-master-addr-by-name' on all
available Sentinels
-Updated naming conventions, removed errant whitespace
Coding standards and conventions update
88ac8f5 
-Updated naming conventions for fields
-Removed redundant qualifiers
-Removed unused using
Removing redundant qualifier
538197c
Added ability to use connectionString node
4e77f06 
-Added new function to retrieve value from connectionString
@azurecla
Copy link

azurecla commented Sep 9, 2015

Hi @cjb5790, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

@SiddharthChatrolaMs
Copy link
Contributor

Please add some unit tests and functional tests to test this behaviour.

@gonace
Copy link

gonace commented Dec 3, 2015

It would be awesome if Sentinel support would be added. Is there anything you need help with?

@SiddharthChatrolaMs
Copy link
Contributor

@gonace Please add some unit tests and functional tests to test this behavior.

@wakm
Copy link

wakm commented Dec 30, 2015

whats the status of this pull request?

@SiddharthChatrolaMs
Copy link
Contributor

@wakm @gonace @cjb5790 Please add unit tests and functional tests to test this behavior.

Also resolve merge conflicts.

@nayr006
Copy link

nayr006 commented May 31, 2017

What is the status of this pull request?

@mapalan
Copy link
Member

mapalan commented May 15, 2020 •
edited
Loading

I believe that this works now due to enhancements in StackExchange.Redis, as mentioned here. Is connecting to sentinels an issue you are still having?

@stanleysmall-microsoft stanleysmall-microsoft changed the base branch from master to main May 11, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cjb5790 @azurecla @SiddharthChatrolaMs @gonace @wakm @nayr006 @mapalan @msftgits