Respect validation serialization (#1080)

Azure · Nov 5, 2021 · a2da42a · a2da42a
1 parent 5060112
commit a2da42a
Show file tree

Hide file tree

Showing 340 changed files with 337 additions and 47 deletions.
diff --git a/ChangeLog.md b/ChangeLog.md
@@ -1,5 +1,19 @@
 # Change Log
 
+### 2021-11-05 - 5.11.2
+
+| Library | Min Version
+| --------------- | -------
+|`@autorest/core` |  `3.6.2`
+|`@autorest/modelerfour` | `4.19.1`
+|`azure-core` dep of generated code | `1.20.0`
+|`msrest` dep of generated code | `0.6.21`
+|`azure-mgmt-core` dep of generated code (If generating mgmt plane code) | `1.3.0`
+
+**Bug Fixes**
+
+- Respect no client side validation for low level client generations  #1080
+
 ### 2021-11-05 - 5.11.1
 
 | Library | Min Version

diff --git a/autorest/codegen/templates/operation_tools.jinja2 b/autorest/codegen/templates/operation_tools.jinja2
@@ -48,3 +48,10 @@ Example:
 
     {% endif %}
 {% endfor %}{% endmacro %}
+
+{% macro declare_serializer(code_model) %}
+_SERIALIZER = Serializer()
+    {% if not code_model.options["client_side_validation"] %}
+_SERIALIZER.client_side_validation = False
+    {% endif %}
+{% endmacro %}
diff --git a/autorest/codegen/templates/operations_container.py.jinja2 b/autorest/codegen/templates/operations_container.py.jinja2
@@ -1,3 +1,4 @@
+{% import 'operation_tools.jinja2' as op_tools %}
 {% set object_base_class = "" if async_mode else "(object)" %}
 {% set operations_description = "async operations" if async_mode else "operations" %}
 {% set return_none_type_annotation = " -> None" if async_mode else "" %}
@@ -7,8 +8,8 @@
 {{ imports }}
 
 {% if code_model.options["builders_visibility"] == "embedded" and not async_mode %}
-_SERIALIZER = Serializer()
-{% if not is_python_3_file %}
+{{ op_tools.declare_serializer(code_model) }}
+{%- if not is_python_3_file %}
 # fmt: off
 {% endif %}
 {% if not code_model.options['combine_operation_files'] %}

diff --git a/autorest/codegen/templates/operations_container_mixin.py.jinja2 b/autorest/codegen/templates/operations_container_mixin.py.jinja2
@@ -1,12 +1,13 @@
+{% import 'operation_tools.jinja2' as op_tools %}
 {% set object_base_class = "" if async_mode else "(object)" %}
 {% set operation_group = operation_groups[0] %}
 # coding=utf-8
 {{ code_model.options['license_header'] }}
 {{ imports }}
 
 {% if code_model.options["builders_visibility"] == "embedded" and not async_mode %}
-_SERIALIZER = Serializer()
-{% if not is_python_3_file %}
+{{ op_tools.declare_serializer(code_model) }}
+{%- if not is_python_3_file %}
 # fmt: off
 {% endif %}
     {% for request_builder in code_model.rest.request_builders | selectattr("builder_group_name", "equalto", "") %}

diff --git a/autorest/codegen/templates/request_builders.py.jinja2 b/autorest/codegen/templates/request_builders.py.jinja2
@@ -1,9 +1,9 @@
+{% import 'operation_tools.jinja2' as op_tools %}
 # coding=utf-8
 {{ code_model.options['license_header'] }}
 {{ imports }}
 
-_SERIALIZER = Serializer()
-
+{{ op_tools.declare_serializer(code_model) }}
 {% if not is_python_3_file %}
 # fmt: off
 {% endif %}

diff --git a/...y_credential/generated/azure/key/credential/sample/operations/_http_success_operations.py b/...y_credential/generated/azure/key/credential/sample/operations/_http_success_operations.py
@@ -25,6 +25,7 @@
     ClsType = Optional[Callable[[PipelineResponse[HttpRequest, HttpResponse], T, Dict[str, Any]], Any]]
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 # fmt: off
 
 def build_head200_request(

diff --git a/...s/specification/basic/generated/azure/basic/sample/operations/_http_success_operations.py b/...s/specification/basic/generated/azure/basic/sample/operations/_http_success_operations.py
@@ -25,6 +25,7 @@
     ClsType = Optional[Callable[[PipelineResponse[HttpRequest, HttpResponse], T, Dict[str, Any]], Any]]
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 # fmt: off
 
 def build_head200_request(

diff --git a/...ctives/generated/azure/directives/sample/operations/_polling_paging_example_operations.py b/...ctives/generated/azure/directives/sample/operations/_polling_paging_example_operations.py
@@ -28,6 +28,7 @@
     ClsType = Optional[Callable[[PipelineResponse[HttpRequest, HttpResponse], T, Dict[str, Any]], Any]]
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 # fmt: off
 
 def build_basic_polling_request_initial(

diff --git a/...ecification/management/generated/azure/mgmt/sample/operations/_http_success_operations.py b/...ecification/management/generated/azure/mgmt/sample/operations/_http_success_operations.py
@@ -26,6 +26,7 @@
     ClsType = Optional[Callable[[PipelineResponse[HttpRequest, HttpResponse], T, Dict[str, Any]], Any]]
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 # fmt: off
 
 def build_head200_request(

diff --git a/...iapi/generated/azure/multiapi/sample/v1/operations/_multiapi_service_client_operations.py b/...iapi/generated/azure/multiapi/sample/v1/operations/_multiapi_service_client_operations.py
@@ -30,6 +30,7 @@
     ClsType = Optional[Callable[[PipelineResponse[HttpRequest, HttpResponse], T, Dict[str, Any]], Any]]
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 # fmt: off
 
 def build_test_one_request(

diff --git a/...multiapi/generated/azure/multiapi/sample/v1/operations/_operation_group_one_operations.py b/...multiapi/generated/azure/multiapi/sample/v1/operations/_operation_group_one_operations.py
@@ -27,6 +27,7 @@
     ClsType = Optional[Callable[[PipelineResponse[HttpRequest, HttpResponse], T, Dict[str, Any]], Any]]
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 # fmt: off
 
 def build_test_two_request(

diff --git a/...iapi/generated/azure/multiapi/sample/v2/operations/_multiapi_service_client_operations.py b/...iapi/generated/azure/multiapi/sample/v2/operations/_multiapi_service_client_operations.py
@@ -27,6 +27,7 @@
     ClsType = Optional[Callable[[PipelineResponse[HttpRequest, HttpResponse], T, Dict[str, Any]], Any]]
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 # fmt: off
 
 def build_test_one_request(

diff --git a/...multiapi/generated/azure/multiapi/sample/v2/operations/_operation_group_one_operations.py b/...multiapi/generated/azure/multiapi/sample/v2/operations/_operation_group_one_operations.py
@@ -27,6 +27,7 @@
     ClsType = Optional[Callable[[PipelineResponse[HttpRequest, HttpResponse], T, Dict[str, Any]], Any]]
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 # fmt: off
 
 def build_test_two_request(

diff --git a/...multiapi/generated/azure/multiapi/sample/v2/operations/_operation_group_two_operations.py b/...multiapi/generated/azure/multiapi/sample/v2/operations/_operation_group_two_operations.py
@@ -27,6 +27,7 @@
     ClsType = Optional[Callable[[PipelineResponse[HttpRequest, HttpResponse], T, Dict[str, Any]], Any]]
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 # fmt: off
 
 def build_test_four_request(

diff --git a/...iapi/generated/azure/multiapi/sample/v3/operations/_multiapi_service_client_operations.py b/...iapi/generated/azure/multiapi/sample/v3/operations/_multiapi_service_client_operations.py
@@ -28,6 +28,7 @@
     ClsType = Optional[Callable[[PipelineResponse[HttpRequest, HttpResponse], T, Dict[str, Any]], Any]]
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 # fmt: off
 
 def build_test_paging_request(

diff --git a/...multiapi/generated/azure/multiapi/sample/v3/operations/_operation_group_one_operations.py b/...multiapi/generated/azure/multiapi/sample/v3/operations/_operation_group_one_operations.py
@@ -27,6 +27,7 @@
     ClsType = Optional[Callable[[PipelineResponse[HttpRequest, HttpResponse], T, Dict[str, Any]], Any]]
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 # fmt: off
 
 def build_test_two_request(

diff --git a/...multiapi/generated/azure/multiapi/sample/v3/operations/_operation_group_two_operations.py b/...multiapi/generated/azure/multiapi/sample/v3/operations/_operation_group_two_operations.py
@@ -27,6 +27,7 @@
     ClsType = Optional[Callable[[PipelineResponse[HttpRequest, HttpResponse], T, Dict[str, Any]], Any]]
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 # fmt: off
 
 def build_test_four_request(

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@autorest/python",
-    "version": "5.11.1",
+    "version": "5.11.2",
     "description": "The Python extension for generators in AutoRest.",
     "scripts": {
         "prepare": "node run-python3.js prepare.py",

diff --git a/tasks.py b/tasks.py
@@ -154,6 +154,7 @@ def _build_flags(
     namespace = kwargs.pop("namespace", _OVERWRITE_DEFAULT_NAMESPACE.get(package_name, package_name.lower()))
     low_level_client = kwargs.pop("low_level_client", False)
     version_tolerant = kwargs.pop("version_tolerant", False)
+    client_side_validation = package_name in _PACKAGES_WITH_CLIENT_SIDE_VALIDATION
     if low_level_client:
         package_name += "LowLevel"
         generation_section += "/low-level"
@@ -186,7 +187,7 @@ def _build_flags(
         "azure-arm": swagger_group == _SwaggerGroup.AZURE_ARM,
         "keep-version-file": True,
         "namespace": namespace,
-        "client-side-validation": package_name in _PACKAGES_WITH_CLIENT_SIDE_VALIDATION,
+        "client-side-validation": client_side_validation,
         "black": True,
     }
     if override_flags:

diff --git a/...xpected/AcceptanceTests/AzureBodyDuration/bodyduration/operations/_duration_operations.py b/...xpected/AcceptanceTests/AzureBodyDuration/bodyduration/operations/_duration_operations.py
@@ -34,6 +34,7 @@
     ClsType = Optional[Callable[[PipelineResponse[HttpRequest, HttpResponse], T, Dict[str, Any]], Any]]
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 # fmt: off
 
 def build_get_null_request(

diff --git a/...ests/AzureReport/azurereport/operations/_auto_rest_report_service_for_azure_operations.py b/...ests/AzureReport/azurereport/operations/_auto_rest_report_service_for_azure_operations.py
@@ -33,6 +33,7 @@
     ClsType = Optional[Callable[[PipelineResponse[HttpRequest, HttpResponse], T, Dict[str, Any]], Any]]
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 # fmt: off
 
 def build_get_report_request(

diff --git a/...cted/AcceptanceTests/CustomPollerPager/custompollerpager/operations/_paging_operations.py b/...cted/AcceptanceTests/CustomPollerPager/custompollerpager/operations/_paging_operations.py
@@ -31,6 +31,7 @@
     ClsType = Optional[Callable[[PipelineResponse[HttpRequest, HttpResponse], T, Dict[str, Any]], Any]]
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 # fmt: off
 
 def build_get_no_item_name_pages_request(

diff --git a/...cted/AcceptanceTests/CustomUrlPaging/custombaseurlpaging/operations/_paging_operations.py b/...cted/AcceptanceTests/CustomUrlPaging/custombaseurlpaging/operations/_paging_operations.py
@@ -34,6 +34,7 @@
     ClsType = Optional[Callable[[PipelineResponse[HttpRequest, HttpResponse], T, Dict[str, Any]], Any]]
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 # fmt: off
 
 def build_get_pages_partial_url_request(

diff --git a/test/azure/legacy/Expected/AcceptanceTests/Head/head/operations/_http_success_operations.py b/test/azure/legacy/Expected/AcceptanceTests/Head/head/operations/_http_success_operations.py
@@ -33,6 +33,7 @@
     ClsType = Optional[Callable[[PipelineResponse[HttpRequest, HttpResponse], T, Dict[str, Any]], Any]]
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 # fmt: off
 
 def build_head200_request(

diff --git a/...ed/AcceptanceTests/HeadExceptions/headexceptions/operations/_head_exception_operations.py b/...ed/AcceptanceTests/HeadExceptions/headexceptions/operations/_head_exception_operations.py
@@ -33,6 +33,7 @@
     ClsType = Optional[Callable[[PipelineResponse[HttpRequest, HttpResponse], T, Dict[str, Any]], Any]]
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 # fmt: off
 
 def build_head200_request(

diff --git a/...yCredentialPolicy/headwithazurekeycredentialpolicy/operations/_http_success_operations.py b/...yCredentialPolicy/headwithazurekeycredentialpolicy/operations/_http_success_operations.py
@@ -33,6 +33,7 @@
     ClsType = Optional[Callable[[PipelineResponse[HttpRequest, HttpResponse], T, Dict[str, Any]], Any]]
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 # fmt: off
 
 def build_head200_request(

diff --git a/...ure/legacy/Expected/AcceptanceTests/Lro/lro/operations/_lr_os_custom_header_operations.py b/...ure/legacy/Expected/AcceptanceTests/Lro/lro/operations/_lr_os_custom_header_operations.py
@@ -36,6 +36,7 @@
     ClsType = Optional[Callable[[PipelineResponse[HttpRequest, HttpResponse], T, Dict[str, Any]], Any]]
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 # fmt: off
 
 def build_put_async_retry_succeeded_request_initial(

diff --git a/test/azure/legacy/Expected/AcceptanceTests/Lro/lro/operations/_lro_retrys_operations.py b/test/azure/legacy/Expected/AcceptanceTests/Lro/lro/operations/_lro_retrys_operations.py
@@ -36,6 +36,7 @@
     ClsType = Optional[Callable[[PipelineResponse[HttpRequest, HttpResponse], T, Dict[str, Any]], Any]]
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 # fmt: off
 
 def build_put201_creating_succeeded200_request_initial(

diff --git a/test/azure/legacy/Expected/AcceptanceTests/Lro/lro/operations/_lros_operations.py b/test/azure/legacy/Expected/AcceptanceTests/Lro/lro/operations/_lros_operations.py
@@ -36,6 +36,7 @@
     ClsType = Optional[Callable[[PipelineResponse[HttpRequest, HttpResponse], T, Dict[str, Any]], Any]]
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 # fmt: off
 
 def build_put200_succeeded_request_initial(

diff --git a/test/azure/legacy/Expected/AcceptanceTests/Lro/lro/operations/_lrosads_operations.py b/test/azure/legacy/Expected/AcceptanceTests/Lro/lro/operations/_lrosads_operations.py
@@ -36,6 +36,7 @@
     ClsType = Optional[Callable[[PipelineResponse[HttpRequest, HttpResponse], T, Dict[str, Any]], Any]]
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 # fmt: off
 
 def build_put_non_retry400_request_initial(

diff --git a/.../lrowithparameterizedendpoints/operations/_lro_with_paramaterized_endpoints_operations.py b/.../lrowithparameterizedendpoints/operations/_lro_with_paramaterized_endpoints_operations.py
@@ -35,6 +35,7 @@
     ClsType = Optional[Callable[[PipelineResponse[HttpRequest, HttpResponse], T, Dict[str, Any]], Any]]
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 # fmt: off
 
 def build_poll_with_parameterized_endpoints_request_initial(

diff --git a/test/azure/legacy/Expected/AcceptanceTests/Paging/paging/operations/_paging_operations.py b/test/azure/legacy/Expected/AcceptanceTests/Paging/paging/operations/_paging_operations.py
@@ -36,6 +36,7 @@
     ClsType = Optional[Callable[[PipelineResponse[HttpRequest, HttpResponse], T, Dict[str, Any]], Any]]
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 # fmt: off
 
 def build_get_no_item_name_pages_request(

diff --git a/...cceptanceTests/StorageManagementClient/storage/operations/_storage_accounts_operations.py b/...cceptanceTests/StorageManagementClient/storage/operations/_storage_accounts_operations.py
@@ -37,6 +37,7 @@
     ClsType = Optional[Callable[[PipelineResponse[HttpRequest, HttpResponse], T, Dict[str, Any]], Any]]
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 # fmt: off
 
 def build_check_name_availability_request(

diff --git a/.../Expected/AcceptanceTests/StorageManagementClient/storage/operations/_usage_operations.py b/.../Expected/AcceptanceTests/StorageManagementClient/storage/operations/_usage_operations.py
@@ -34,6 +34,7 @@
     ClsType = Optional[Callable[[PipelineResponse[HttpRequest, HttpResponse], T, Dict[str, Any]], Any]]
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 # fmt: off
 
 def build_list_request(

diff --git a/...ceTests/SubscriptionIdApiVersion/subscriptionidapiversion/operations/_group_operations.py b/...ceTests/SubscriptionIdApiVersion/subscriptionidapiversion/operations/_group_operations.py
@@ -34,6 +34,7 @@
     ClsType = Optional[Callable[[PipelineResponse[HttpRequest, HttpResponse], T, Dict[str, Any]], Any]]
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 # fmt: off
 
 def build_get_sample_resource_group_request(

diff --git a/...ceTests/AzureBodyDurationLowLevel/bodydurationlowlevel/rest/duration/_request_builders.py b/...ceTests/AzureBodyDurationLowLevel/bodydurationlowlevel/rest/duration/_request_builders.py
@@ -19,6 +19,7 @@
     JSONType = Any
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 
 # fmt: off
 

diff --git a/...sts/AzureBodyDurationLowLevel/bodydurationlowlevel/rest/duration/_request_builders_py3.py b/...sts/AzureBodyDurationLowLevel/bodydurationlowlevel/rest/duration/_request_builders_py3.py
@@ -15,6 +15,7 @@
 JSONType = Any
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 
 
 def build_get_null_request(**kwargs: Any) -> HttpRequest:

diff --git a/...pingLowLevel/azureparametergroupinglowlevel/_auto_rest_parameter_grouping_test_service.py b/...pingLowLevel/azureparametergroupinglowlevel/_auto_rest_parameter_grouping_test_service.py
@@ -39,7 +39,6 @@ def __init__(
 
         self._serialize = Serializer()
         self._deserialize = Deserializer()
-        self._serialize.client_side_validation = False
 
     def send_request(
         self,

diff --git a/...LowLevel/azureparametergroupinglowlevel/aio/_auto_rest_parameter_grouping_test_service.py b/...LowLevel/azureparametergroupinglowlevel/aio/_auto_rest_parameter_grouping_test_service.py
@@ -33,7 +33,6 @@ def __init__(self, *, endpoint: str = "http://localhost:3000", **kwargs: Any) ->
 
         self._serialize = Serializer()
         self._deserialize = Deserializer()
-        self._serialize.client_side_validation = False
 
     def send_request(self, request: HttpRequest, **kwargs: Any) -> Awaitable[AsyncHttpResponse]:
         """Runs the network request through the client's chained policies.

diff --git a/...xpected/AcceptanceTests/AzureReportLowLevel/azurereportlowlevel/rest/_request_builders.py b/...xpected/AcceptanceTests/AzureReportLowLevel/azurereportlowlevel/rest/_request_builders.py
@@ -15,6 +15,7 @@
     from typing import Any, Optional
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 
 # fmt: off
 

diff --git a/...ted/AcceptanceTests/AzureReportLowLevel/azurereportlowlevel/rest/_request_builders_py3.py b/...ted/AcceptanceTests/AzureReportLowLevel/azurereportlowlevel/rest/_request_builders_py3.py
@@ -11,6 +11,7 @@
 from msrest import Serializer
 
 _SERIALIZER = Serializer()
+_SERIALIZER.client_side_validation = False
 
 
 def build_get_report_request(*, qualifier: Optional[str] = None, **kwargs: Any) -> HttpRequest:

diff --git a/...owLevel/azurespecialpropertieslowlevel/_auto_rest_azure_special_parameters_test_client.py b/...owLevel/azurespecialpropertieslowlevel/_auto_rest_azure_special_parameters_test_client.py
@@ -53,7 +53,6 @@ def __init__(
 
         self._serialize = Serializer()
         self._deserialize = Deserializer()
-        self._serialize.client_side_validation = False
 
     def send_request(
         self,

diff --git a/...vel/azurespecialpropertieslowlevel/aio/_auto_rest_azure_special_parameters_test_client.py b/...vel/azurespecialpropertieslowlevel/aio/_auto_rest_azure_special_parameters_test_client.py
@@ -52,7 +52,6 @@ def __init__(
 
         self._serialize = Serializer()
         self._deserialize = Deserializer()
-        self._serialize.client_side_validation = False
 
     def send_request(self, request: HttpRequest, **kwargs: Any) -> Awaitable[AsyncHttpResponse]:
         """Runs the network request through the client's chained policies.

diff --git a/.../CustomBaseUriLowLevel/custombaseurllowlevel/_auto_rest_parameterized_host_test_client.py b/.../CustomBaseUriLowLevel/custombaseurllowlevel/_auto_rest_parameterized_host_test_client.py
@@ -40,7 +40,6 @@ def __init__(
 
         self._serialize = Serializer()
         self._deserialize = Deserializer()
-        self._serialize.client_side_validation = False
 
     def send_request(
         self,