Add Java analyzer #4422
Closed
Add Java analyzer #4422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support adding MySQL when run `azd init`
Fix typo by changing "DbMysql" to "DbMySql"
…or like this: "argetTypeNotSupported: Target resource type MICROSOFT.DBFORMYSQL/FLEXIBLESERVERS is not supported.".
2. Delete '1>&2' used for debug. 3. Add 'az tag create' to fix the problem about tag been deleted when creating service connector.
Use managed-identity instead of username and password
2. Update log about "failed to read spring application properties". 3. Fix bug about can not find frontend app and backend app at the same time. 4. Add service connector from aca to postgresql.
Use passwordless to connect to PostgreSQL in Azure Container Apps
weikanglim
reviewed
Oct 11, 2024
| } | ||
| defer xmlFile.Close() | ||
|
|
||
| bytes, err := ioutil.ReadAll(xmlFile) |
There was a problem hiding this comment.
I think the linter may catch this: ioutil.ReadAll is deprecated, we now use os.ReadFile. Once we do this, we can avoid os.Open and file.Close() entirely.
| } | ||
|
|
||
| func analyzeMavenProject(projectPath string) ([]mavenProject, error) { | ||
| rootProject, _ := analyze(projectPath + "/pom.xml") |
There was a problem hiding this comment.
Use filepath.Join so that os.Separator is used -- / on linux and \ on Windows.
There was a problem hiding this comment.
Applies elsewhere as well.
| // if it has submodules | ||
| if len(rootProject.Modules) > 0 { | ||
| for _, m := range rootProject.Modules { | ||
| subModule, _ := analyze(projectPath + "/" + m + "/pom.xml") |
There was a problem hiding this comment.
Do check and return err if there was an error reading the file.
Comment on lines
+12
to
+13
| rules := []rule{ | ||
| &ruleService{}, |
There was a problem hiding this comment.
I think we can replace these rules with switch statements like Python, and I feel comfortable moving all the logic here into java.go.
weikanglim
reviewed
Oct 11, 2024
| @@ -123,6 +136,7 @@ resource app 'Microsoft.App/containerApps@2023-05-02-preview' = { | |||
| allowedOrigins: union(allowedOrigins, [ | |||
| // define additional allowed origins here | |||
| ]) | |||
| allowedMethods: ['GET', 'PUT', 'POST', 'DELETE'] | |||
There was a problem hiding this comment.
Was this giving you trouble? I was under the impression that the default value is allowedMethods: [*], but if not, we can make that explicit. I'd prefer allowedMethods: [*] over what we have currently.
This was referenced Oct 11, 2024
Support both password and passwordless auth type for PostgreSQL and MySQL
Support monolithic web application with Database access - MongoDB - Password
Fix bug: Get auth type should only be required for MySQL and PostgreSQL
…erver.port" is set in application.properties.
Make sure app work well after deployed to ACA no matter what value "server.port" is set in application.properties
Implement feature: detect port in Dockerfile
Implement feature: detect redis by analyzing pom file
…ve just like spring-boot-starter-data-mongodb
Detect Mongo DB by dependency spring-boot-starter-data-mongodb-reactive just like spring-boot-starter-data-mongodb
…or yaml, properties)
Support all kinds of properties file like application(-profile).yaml(or yaml, properties)
VSCode Extension Installation Instructions
|
Draft
|
Superseded by #4473 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the extensible Java analyzer for azd, to further understand a Java project.