-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[page-blob] introduce IfMatch header to put request #1850
base: legacy
Are you sure you want to change the base?
Conversation
The Azure Docs do not mention, but we can prevent accidental overwrites to Azure Page Blobs when two parties issue a create request. This can be prevented through IfMatch headers, as this commit introduces. For C# equivelant, please see: https://github.com/Azure/azure-sdk-for-net/blob/fb0b80d4c8fc99e9e964862f2a374d2bc28096f7/sdk/storage/Azure.Storage.Blobs/src/PageBlobClient.cs#L844
@microsoft-github-policy-service agree company="Microsoft" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main
branch is unsupported and should not be used in production. You might want to check if this is already implemented in the feature/track2
branch or retarget there if not.
hey @heaths , thanks for quick response. I don't see any code under storage directory in the branch you've suggested. I assume that is still under development. But, please redirect me otherwise. Thanks! |
The storage team is working on a new crate. Keep in mind what's under |
|
@heaths , would it be possible to merge this to "legacy" branch? We'll possibly use cargo syntax to consume this specific change to simplify the code until we acquire more clarity around official Azure Storage SDK. |
@goksgie you already can without me merging it. Just point to your topic branch. Even if I did merge it, we have no plans for further releases from the |
The Azure Docs do not mention, but we can prevent accidental overwrites to Azure Page Blobs when two parties issue a create request. This can be prevented through IfMatch headers, as this commit introduces.
As of today, the only alternative option to prevent overwrite would be managing an internal blob service, or checking whether it exists before issuing a create request (which introduces an additional round-trip).
For C# equivalent, please see: https://github.com/Azure/azure-sdk-for-net/blob/fb0b80d4c8fc99e9e964862f2a374d2bc28096f7/sdk/storage/Azure.Storage.Blobs/src/PageBlobClient.cs#L844