[Feature] Add Chat Typing Indicator #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpeng-ms
requested review from
waynemo,
palatter,
AmyL219,
emlynmac,
JoshuaLai,
vhuseinova-msft and
Leah-Xia-Microsoft
emlynmac
reviewed
Oct 18, 2022
.../sdk/AzureCommunicationUICalling/Sources/Presentation/FluentUI/Wrapper/CompositeAvatar.swift
Outdated
Show resolved
Hide resolved
...icationUI/sdk/AzureCommunicationUIChat/Sources/Presentation/Style/LocalizationProvider.swift
Show resolved
Hide resolved
...IChat/Sources/Presentation/SwiftUI/Chat/ChatViewComponents/TypingParticipantsViewModel.swift
Outdated
Show resolved
Hide resolved
jpeng-ms
changed the title
jimchou-dev
reviewed
Oct 18, 2022
AzureCommunicationUI/sdk/AzureCommunicationUIChat/Sources/Redux/Action/ChatAction.swift
Outdated
Show resolved
Hide resolved
...CommunicationUI/sdk/AzureCommunicationUIChat/Sources/Redux/Reducer/ParticipantsReducer.swift
Outdated
Show resolved
Hide resolved
...IChat/Sources/Presentation/SwiftUI/Chat/ChatViewComponents/TypingParticipantsViewModel.swift
Outdated
Show resolved
Hide resolved
palatter
reviewed
Oct 20, 2022
...CommunicationUIChat/Sources/Presentation/FluentUI/Wrapper/TypingParticipantAvatarGroup.swift
Show resolved
Hide resolved
palatter
reviewed
Oct 20, 2022
...tionUIChat/Sources/Presentation/SwiftUI/Chat/ChatViewComponents/TypingParticipantsView.swift
Outdated
Show resolved
Hide resolved
jpeng-ms
changed the title
jpeng-ms
added
feature
palatter
reviewed
Oct 20, 2022
...tionUIChat/Sources/Presentation/SwiftUI/Chat/ChatViewComponents/TypingParticipantsView.swift
Show resolved
Hide resolved
jimchou-dev
reviewed
Oct 21, 2022
...IChat/Sources/Presentation/SwiftUI/Chat/ChatViewComponents/TypingParticipantsViewModel.swift
Show resolved
Hide resolved
AzureCommunicationUI/sdk/AzureCommunicationUIChat/Sources/Redux/State/ParticipantsState.swift
Show resolved
Hide resolved
...CommunicationUI/sdk/AzureCommunicationUIChat/Sources/Redux/Reducer/ParticipantsReducer.swift
Show resolved
Hide resolved
Leah-Xia-Microsoft
previously approved these changes
Oct 21, 2022
jpeng-ms
dismissed stale reviews from Leah-Xia-Microsoft and jimchou-dev
via
33b4e5b
|
merging this since I had enough approvals prior to resolving conflicts and Jim is OOO. |
emlynmac
added a commit
that referenced
this pull request
Dec 13, 2022
* [Feature] Chat Composite project skeleton structure (#339) * [Feature] Added skeleton structure/files for chat unit test (#349) * [Feature][Chat] Added skeleton structure for chat redux (#346) * [Feature] Implemented Dependency Injection for chat composite (#361) * [Feature] Implemented chat initialization in ChatService (#370) * [Feature] Basic Chat Views (#377) * [Feature] Implemented fetch initial messages (#379) * [Feature] Chat realtime notification for receive message (#385) * [Task] Handle Chat Typing Indicator Receiving (#390) * [Feature] Implemented event handlers for service layer for Chat Composite (#391) * [Feature] Handling TrouterEvent for message edit and delete event for Chat service layer (#393) * [Feature] Implemented send message for ChatComposite (#397) * [Task] Synced Chat views with Android and Figma (#396) * [Feature] Implemented chat message history pagination (#402) * [Task] Message view models and list formatting (#405) * [Feature] Implemented redux for Chat Service events (#408) * [Feature] Add Chat Typing Indicator (#399) * [Feature] Adding new skeleton for add / remove participant event (#410) * [Task] Send read receipt service redux layer (#404) * [Feature] Adding in new unit tests to RepositoryMiddlewareHandlerTests(#413) * [Feature] Chat scrolling, formatting and message types (#412) * [Feature] Making the service call to request list of participants (#418) * [Feature] Send read receipt presentation layer (#415) * [Feature] Implement Telemetry for chat (#426) * [Feature] service layer for receiving read receipt (#427) * [Task] chat typing clear logic update (#421) * [Refactor] Update Chat to use the common code package (#444) * [Task] Create custom scrolling view and update icon sizing for Chat (#425) * [Feature] Implemented service/redux layer for chat participants (#441) * [Task] Update initial number of messages loaded. (#453) * [Bugfix] Resolved presentation bugs (#457) * [Feature] Implemented service layer and redux layer for editing/deleting message (#455) * [Task] Add Basic Error Handling (#452) * [Task] Handling Local User Removed (#450) * [Feature] Redux layer and Presentation layer for receive read receipt (#448) * [Refactor] Refactor and renaming of public api for chat (#458) * [Bugfix] Not rendering edited/deleted message correctly (#461) * [Task] Back merge develop to feature/chat (#463) * [Feature] Mask admin user from read receipt and participant added message (#462) * [Bugfix] Chat bug fixes for layout, skip messages button, keyboard, and message input (#470) * [Refactor] Clean up public api and unused error codes (#465) * [Refactor] Refactoring isLocalUser for ChatMessageInfoModel (#473) * [Feature] Chat parse Teams html RichText message (#474) * [Task] Back merge develop to feature/chat (#482) * [Bugfix] Fix new thread mask admin user crash (#483) * [Feature] Filter trouter event for current threadId only (#469) * [Task] Back merge develop to feature/chat (#488) * [Refactor][Bugfix] Refactor messages to no longer use viewmodels and move refactor read Icon logic (#480) * [BugFix] Put back changes lost in back merge (#498) * [Task] Display html msg for Teams messages (#492) * [Refactor] Clarify dependency construction for chat library (#494) * Send read receipt when scroll to then end of the screen (#490) * [Bugfix] Fix adding duplicate messages to MessageRepositorymanager's messages (#500) * [Bugfix] Remove scroll indicator and send button fixes (#499) * [Bug] Demo App Needs Rotation Disabled (#504) * [Task] Add Alert to Demo App (#489) * [Feature] Implement message send status (Sending, delivered, failed) (#506) * [Refactor] Set isLocalUser for Participant Info Model (#503) * [Doc] Updated Readme (#491) * [Feature] Introduce the Chat podspec (#508) * [Refactor] Move threadId out from ChatConfiguration (#513) Co-authored-by: Jim Chou <[email protected]> Co-authored-by: Patrick Latter <[email protected]> Co-authored-by: John <[email protected]> Co-authored-by: JoshuaLai <[email protected]> Co-authored-by: Leah Xia <[email protected]> Co-authored-by: Josh Lai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR added typing indicator presentation layer:
test.mov
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
Other Information