Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add days 1-4 #3

Merged
merged 4 commits into from
Dec 4, 2024
Merged

add days 1-4 #3

merged 4 commits into from
Dec 4, 2024

Conversation

alv67
Copy link
Member

@alv67 alv67 commented Dec 4, 2024

πŸ“‘ Description

Closes #

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

@gmacario
Copy link
Member

gmacario commented Dec 4, 2024

As a personal preference and to minimize issues when checking out the repository from different OSs, I would tend to use lowercase characters for the directories, i.e. solutions/$USER/day01 rather than solutions/$USER/Day01

Apart from that, LGTM. Merging PR

Copy link
Member

@gmacario gmacario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

@gmacario gmacario added the enhancement New feature or request label Dec 4, 2024
@gmacario gmacario merged commit 29aa5e3 into main Dec 4, 2024
15 checks passed
@gmacario gmacario deleted the alv67 branch December 4, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants