Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

device_read2table --> listdevice #299

Merged
merged 1 commit into from
Apr 29, 2024
Merged

device_read2table --> listdevice #299

merged 1 commit into from
Apr 29, 2024

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian added the documentation Improvements or additions to documentation label Apr 28, 2024
@prjemian prjemian added this to the v1.0.3 milestone Apr 28, 2024
@prjemian prjemian self-assigned this Apr 28, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8869693141

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 82.675%
Files with Coverage Reduction New Missed Lines %
bluesky/instrument/devices/temperature_signal.py 1 93.22%
Totals Coverage Status
Change from base Build 8607748681: -0.08%
Covered Lines: 983
Relevant Lines: 1189
💛 - Coveralls

@prjemian
Copy link
Contributor Author

To re-generate the notebooks, BCDA-APS/apstools#972 is needed to interact with the aps object again. This PR (which so far only changes the name of the function called) could be merged but the output will not match. It could be weeks until the PVs become available again.

I suggest merging now, with an additional issue to re-run the notebooks once the aps device is updated.

@prjemian prjemian marked this pull request as ready for review April 29, 2024 16:40
MDecarabas
MDecarabas approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@MDecarabas MDecarabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@prjemian prjemian merged commit 800519c into main Apr 29, 2024
7 checks passed
@prjemian prjemian deleted the 253-listdevice branch April 29, 2024 17:03
@prjemian
Copy link
Contributor Author

@MDecarabas Thanks!

@prjemian prjemian mentioned this pull request Apr 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDecarabas MDecarabas MDecarabas approved these changes

@mdwyman mdwyman Awaiting requested review from mdwyman

@rodolakis rodolakis Awaiting requested review from rodolakis

Assignees

@prjemian prjemian

Labels
documentation Improvements or additions to documentation
Projects
No open projects
bluesky_training v1.0.3 project
Status: Done
Milestone
v1.0.3
Development

Successfully merging this pull request may close these issues.

DOC: apstools.utils.device_read2table has been replaced by aps.utils.listdevice
3 participants
@prjemian @coveralls @MDecarabas