Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fix building_your_first_artkit_pipeline.ipynb #76

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

Tiger-Du
Copy link
Contributor

@Tiger-Du Tiger-Du commented Sep 28, 2024

Description

This PR is to remove an unused variable, prompt, from building_your_first_artkit_pipeline.ipynb as described in Issue #70.

It turns out that prompt is a duplicate of another variable named question in the previous cell.

In addition, question is used in a function call in the same cell as prompt, and since the definition of question is not in the immediate context (it is in the previous cell), I thought that it would be nice to modify the comment above the function call so that its use might be more clear to readers.

Issue number and link: #70

PR checks:

  • Have you followed our PR guidelines document
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you set these PR fields: Reviewers, Assignees, Labels, Milestones
  • Have you updated RELEASE_NOTES.rst, if applicable?
  • Have you updated existing and/or created new unit tests for your changes?

@rgriff23 rgriff23 self-requested a review October 23, 2024 16:30
@rgriff23 rgriff23 added the documentation Improvements or additions to documentation label Oct 23, 2024
@rgriff23 rgriff23 merged commit 82c7eb9 into BCG-X-Official:1.0.x Oct 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants