-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowing the users to append their filters into the existing BEAST filter library #756
Open
galaxyumi
wants to merge
6
commits into
BEAST-Fitting:master
Choose a base branch
from
galaxyumi:add_user_filter
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f35f911
fix a typo and update for adding filter description
galaxyumi 18bd626
describe how to append a new filter to the BEAST filter lib
galaxyumi 7521ac2
update code to enable adding a new filter from a command line
galaxyumi 2666c75
fix codstyle issue
galaxyumi 0548844
fix codestyle issue
galaxyumi eae674a
fix codestyle issue
galaxyumi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
############## | ||
Append filters | ||
############## | ||
|
||
Users can add any filters into their local ``beast/libs/filters.hd5``. | ||
The list of default filters in the BEAST filter library can be found `<here https://beast.readthedocs.io/en/latest/beast_setup.html#beast-filters>`_. | ||
|
||
If you need to include fluxes in particular bands in your SED fitting or BEAST | ||
predictions but those particular bands do not exist in the BEAST filter library, | ||
you should append those filters to the BEAST filter library before generating | ||
your physics model grid. To do this, you need an ascii file that has two columns: | ||
wavelegnth in angstrom and thoughput. The BEAST filter library requires basic information | ||
about the filter. This includes the tablename for the filter information (e.g., HST_WFC3_F275W), | ||
observatorty associated with the filter (e.g., HST), instrument of the filter (e.g., WFC3), | ||
and name of the filter (e.g., F275W). | ||
|
||
Command to add a filter to the BEAST filter library. | ||
|
||
.. code-block:: console | ||
|
||
$ python -m beast.observationmodel.phot filter_curve_file --tablename tablename | ||
--observatory observatory --instrument instrument --filtername filtername | ||
karllark marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be a separate script in the tools subdir instead of added to phot.py. For consistency with how similar capabilities are handled in the BEAST.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense. Will start a separate script for this functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This task could be merged with the outstanding WIP PR #646!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add this script to this PR.