Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review IonTorrent and Nanopore ontologies #358

Open
svarona opened this issue Dec 19, 2024 · 1 comment
Open

Review IonTorrent and Nanopore ontologies #358

svarona opened this issue Dec 19, 2024 · 1 comment
Assignees

Comments

@svarona
Copy link
Member

svarona commented Dec 19, 2024

In Sequencing Instrument Model and Flowcell Kit, some of the IonTorrent and Nanopore kits are missing. Review if the have ontology and add them to the schema.

For example, for IonTorrent Sequencing Instrument Model, the official name is:
Ion GeneStudio S5 Prime
Ion GeneStudio S5 Plus
Ion GeneStudio S5

But in the schema, the ontologies found where for
Ion Torrent S5
Ion Torrent S5 XL

Check all of them

@Aberdur
Copy link

Aberdur commented Dec 19, 2024

I have reviewed the ontologies. For the Sequencing Instrument Model, the ontologies have been checked and corrected where mismatches were found. However, for the specific examples mentioned, there is no ontology available for 'Ion Torrent S5' and 'Ion Torrent S5 XL'; instead, ontologies exist for 'Ion GeneStudio S5 Prime,' 'Ion GeneStudio S5 Plus,' and 'Ion GeneStudio S5.'
Regarding the Flowcell Kit, there is no ontology available for any of the enums.

I checked the particular case of Ion Torrent vs Ion GeneStudio and the official name of the instrument is “Ion GeneStudio S *” while the Torrent is a “colloquial” addition.

The schema will be updated by running build_schema.py with the new updated excel with the evaluated ontologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants