-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: sync bgfx and bump ios-cmake #1408
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okwasniewski
force-pushed
the
chore/sync-bgfx
branch
2 times, most recently
from
August 22, 2024 14:05
d3076d2
to
c5df574
Compare
okwasniewski
force-pushed
the
chore/sync-bgfx
branch
from
August 22, 2024 14:20
c5df574
to
b6a7c6f
Compare
5 tasks
Hey @CedricGuillemet @ryantrem, Can you help me out with the Windows build failing? Looks like its something related to |
I'm taking a look |
ryantrem
reviewed
Aug 22, 2024
okwasniewski
commented
Aug 23, 2024
okwasniewski
commented
Aug 23, 2024
okwasniewski
force-pushed
the
chore/sync-bgfx
branch
2 times, most recently
from
August 26, 2024 09:01
a387bb7
to
1d6cb09
Compare
okwasniewski
force-pushed
the
chore/sync-bgfx
branch
from
August 27, 2024 07:57
1d6cb09
to
4683e94
Compare
@CedricGuillemet Looks like the build is green |
CedricGuillemet
approved these changes
Aug 27, 2024
ryantrem
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR syncs bgfx and bumps ios-cmake (contains necessary fixes for visionOS work).