Skip to content
This repository has been archived by the owner on Jun 16, 2024. It is now read-only.

Remove response injection & update interfaces #5

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Remove response injection & update interfaces #5

wants to merge 6 commits into from

Conversation

macnibblet
Copy link

Closes #3 and closes #4

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.26%) when pulling 4d62449 on macnibblet:feature/exchange-interface-and-response into 9d0eaa1 on Bacon:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.25%) when pulling e70ffca on macnibblet:feature/exchange-interface-and-response into 9d0eaa1 on Bacon:master.

@@ -34,6 +33,11 @@ class Session implements
protected $session;

/**
* @var array
*/
protected $listeners = [];
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.24%) when pulling 0bb550a on macnibblet:feature/exchange-interface-and-response into 9d0eaa1 on Bacon:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 08f2b38 on macnibblet:feature/exchange-interface-and-response into 9d0eaa1 on Bacon:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 251d925 on macnibblet:feature/exchange-interface-and-response into 9d0eaa1 on Bacon:master.

@macnibblet
Copy link
Author

Any reason this was not merged ?

@DASPRiD
Copy link
Member

DASPRiD commented Jul 26, 2016

Because pretty dead… ;)

@macnibblet
Copy link
Author

2 years later

@DASPRiD
Copy link
Member

DASPRiD commented Jul 26, 2016

Maybe I'll rewrite it as middleware :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exchange EventAwarePluginInterface with ListenerAggregateInterface Remove Response object fbeing passed down
3 participants