Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow PHPUnit 10 #156

Closed
wants to merge 4 commits into from
Closed

feat: allow PHPUnit 10 #156

wants to merge 4 commits into from

Conversation

Chris53897
Copy link
Contributor

allow "spatie/phpunit-snapshot-assertions" 5

allow "spatie/phpunit-snapshot-assertions" 5
@Chris53897 Chris53897 closed this Mar 5, 2024
@Chris53897 Chris53897 reopened this Mar 5, 2024
allow "spatie/phpunit-snapshot-assertions" 5
allow "spatie/phpunit-snapshot-assertions" 5
allow "spatie/phpunit-snapshot-assertions" 5
@Chris53897 Chris53897 changed the title feat: allow PHPUnit 10/11 feat: allow PHPUnit 10 Mar 5, 2024
@Chris53897
Copy link
Contributor Author

Chris53897 commented Mar 5, 2024

PHPUnit 11 support could be provided with a seperate configuration file with the migrated configuration.
CI needs to be adjusted to read the correct file.
I think it is not worth the effort right now.

@DASPRiD
Copy link
Member

DASPRiD commented Mar 5, 2024

Is there actually any reason to not rely on PHPUnit 11 specifically and ignore all older versions? This is a dev dependency afterall.

@Chris53897
Copy link
Contributor Author

Chris53897 commented Mar 5, 2024

The lowest supported PHP Version is 7.1 "php": "^7.1 || ^8.0",
We need to support PHPUnit 7 until the PHP Min Version is bumped.
https://packagist.org/packages/phpunit/phpunit#7.5.20

@DASPRiD
Copy link
Member

DASPRiD commented Mar 5, 2024

Ah yeah, that makes sense. I wonder if it's safe by now to drop PHP 7 (and 8.0), since those have been EOL for some time. Of course, that'd mean bumping our major version to 3.

@Chris53897
Copy link
Contributor Author

I am in favor of dropping older PHP versions. Min Version PHP ^8.1 ?
https://www.php.net/supported-versions.php

Do your want to work on this, or should i?

@DASPRiD
Copy link
Member

DASPRiD commented Mar 5, 2024

Feel free to go ahead!

@Chris53897
Copy link
Contributor Author

I am working on it

@DASPRiD DASPRiD closed this Mar 18, 2024
@Chris53897 Chris53897 deleted the feature/allow-phpunit-10 branch March 20, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants