Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(people): sort order by last name #138

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(people): sort order by last name #138

wants to merge 1 commit into from

Conversation

louh
Copy link
Member

@louh louh commented Dec 14, 2024

I don't know what the sort by score means since almost everyone has 1 (except for Mark and Annabel). It looks like this causes the published website to sort overlords by first name, then score, but if you're running a local version then all bets are off, it's sorted by random, then score. (With the exception of accomplices, which are sorted by last name.)

I'm proposing to make this consistently sort by first name only across all three categories and removing score from sort order which doesn't seem to serve a purpose (that I know of!)

I kind of like the option of sorting by random, to be honest, but that's not something I think gatsby/graphql can do. (We'd have to tell React to render items at random, which is also fine.)

@louh louh requested a review from slifty December 14, 2024 18:00
@louh louh self-assigned this Dec 14, 2024
@louh louh marked this pull request as ready for review December 14, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant