fix(people): sort order by last name #138
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know what the sort by
score
means since almost everyone has1
(except for Mark and Annabel). It looks like this causes the published website to sort overlords by first name, then score, but if you're running a local version then all bets are off, it's sorted by random, then score. (With the exception of accomplices, which are sorted by last name.)I'm proposing to make this consistently sort by first name only across all three categories and removing
score
from sort order which doesn't seem to serve a purpose (that I know of!)I kind of like the option of sorting by random, to be honest, but that's not something I think gatsby/graphql can do. (We'd have to tell React to render items at random, which is also fine.)