BAH-4052 | Fix. Slot Details Cell View #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahu1ramesh
requested review from
srinithishg,
AshishkurianTw,
binduak,
mohan-13,
kavitha-sundararajan,
Arjun-Go and
parvathy00
mohan-13
reviewed
Aug 1, 2024
| <div | ||
| className="slot-details" | ||
| key={`${taskItem.uuid}`} | ||
| style={{ borderColor: "#0f62fe", background: "#e1f3fe" }} |
There was a problem hiding this comment.
Why are we adding inline styles though we have added class ? Can we keep it consistent by defining a class ?
There was a problem hiding this comment.
Sure Mohan, makes sense. Will do.
| <div | ||
| className="slot-details" | ||
| key={`${slotItem.uuid}`} | ||
| style={{ borderColor: "#92c4c3", background: "#edf8e6" }} |
There was a problem hiding this comment.
same here, using class and as well as inline styling
mohan-13
approved these changes
Aug 1, 2024
rahu1ramesh
added a commit
that referenced
this pull request
Aug 2, 2024
* [Rahul] | BAH-4052 | Fix. Remove Daemon User Tag from Tasks * [Rahul] | BAH-4052 | Add. Border CSS To Slot Details Cell * [Rahul] | BAH-4052 | Add. Task Provider Font Styling * [Rahul] | BAH-4052 | Refactor. Extend Task Cell Styling * [Rahul] | BAH-4052 | Add. Creator Styling In Slot Details Cell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA -> BAH-4052
This PR aims to hide the user name for tasks created by the
daemonuser while preserving it for tasks created by non-system users. This PR also includes changes to the overall look ofSlot Details Cellwhile preserving the overall structure and functionality.