Update transmit in facet to accept bytes array for asset flexibility #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pizzaman1337
commented
Oct 21, 2024
| @@ -25,7 +25,7 @@ contract TransmitOutFacet is Invariable { | |||
| LibTransmitOut.SourceDeposit[] calldata sourceDeposits, | |||
| LibTransmitOut.SourcePlot[] calldata sourcePlots, | |||
| LibTransmitOut.SourceFertilizer[] calldata sourceFertilizer, | |||
| bytes calldata // data | |||
| bytes calldata data | |||
There was a problem hiding this comment.
@funderbrker I removed the // here so that the data var can be passed into the transmitIn function (line 47).
…Beanstalk into transmission-bytes-array
|
lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates TransmitInFacet to handle 2d bytes array for asset transmission flexibility.
(This PR will be updated to merge into the main transmission branch once the master merge branch is merged).
This also includes:
requiretoasserttotalHarvestedandtotalSlashed