Add Linting #128
Open
Add Linting #128
+3,718
−3,435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leptopoda
force-pushed
the
linting
branch
6 times, most recently
from
2c75494 to
84c7233
Compare
Leptopoda
commented
Oct 14, 2022
Comment on lines
45
to
53
| if (result != null && result is! ScheduleQueryResult) { | ||
| // TODO: [Leptopoda] validate changes | ||
| if (result == null || result is! ScheduleQueryResult) { | ||
| potentialException = ScheduleQueryFailedException(result); | ||
| completer.complete(null); | ||
| completer.complete(); | ||
| } else { | ||
| completer.complete(result); | ||
| } |
There was a problem hiding this comment.
I only changed the logic here but it didn't really make sense the other way around.
Please verify that this is still the wanted implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I've added linting using the lint package. The package enables all lints available to flutter (all linting rules are still maintained by the flutter team but they them self consider some as less important or not worth enabling on existing projects) so it is a bit strict. I've also fixed the code style to adapt to the lints and most of the lints I touched would also be in the not so strict flutter_lints package which is maintained by the flutter team itself and also enabled on every new project.
Those lints include code style, formatting style removing of unused variables, code flow cleanup ...
In general those lints improve the code readability and performance of the code (some of the stuff the linter points out should be done by the compiler/optimizer anyways but some aren't an example that isn't touched by the compiler is using StringBuffer to compose strings).