-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme cleanup #131
Open
Leptopoda
wants to merge
37
commits into
Bennik2000:develop
Choose a base branch
from
Leptopoda:theme_cleanup
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Theme cleanup #131
+5,064
−4,142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leptopoda
force-pushed
the
theme_cleanup
branch
2 times, most recently
from
October 16, 2022 12:49
85f02b3
to
c359a47
Compare
now that we use features of dart 2.17 for the theme upgrading everything to it. This also adds default constructors to every widget potentially improving the performance. Nuallybility got a boost aswel.
Leptopoda
force-pushed
the
theme_cleanup
branch
from
October 16, 2022 12:58
c359a47
to
4b266a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clenup the theming of the app.
This PR uses Flutters built in
ThemeMode
enum. Also removes quite a lot of methods to build the theme with static members.Again this PR is based on the others ;)