Skip to content

Commit

Permalink
Improve Type Completeness
Browse files Browse the repository at this point in the history
  • Loading branch information
Bibo-Joshi committed Jun 15, 2024
1 parent 9cabdc1 commit 9625ba2
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
4 changes: 4 additions & 0 deletions .github/workflows/type_completeness_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ jobs:
git checkout ${{ github.base_ref }}
pip install . -U
pyright --verifytypes telegram --ignoreexternal --outputjson > base.json || true
pyright --verifytypes telegram --ignoreexternal > base.readable || true
- name: Compare Completeness
uses: jannekem/run-python-script-action@v1
Expand All @@ -60,6 +61,9 @@ jobs:
if base == 0:
text = f"Something is broken in the workflow. Reported type completeness is 0. 💥"
set_summary(text)
print("pyright report for base branch:")
print(Path("base.readable").read_text(encoding="utf-8"))
print("\n\npyright report for PR branch:")
print(Path("pr.readable").read_text(encoding="utf-8"))
error(text)
exit(1)
Expand Down
4 changes: 3 additions & 1 deletion aiorem/_resourcemanager.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@


class AbstractResourceManager(
contextlib.AbstractAsyncContextManager, contextlib.AsyncContextDecorator, abc.ABC
contextlib.AbstractAsyncContextManager["AbstractResourceManager"],
contextlib.AsyncContextDecorator,
abc.ABC,
):
"""
Abstract base class for asynchronous resource managers.
Expand Down

0 comments on commit 9625ba2

Please sign in to comment.