-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lastguest/murmurhash version update #898
base: master
Are you sure you want to change the base?
Conversation
How about merging this? |
I have the same issue :( |
@@ -26,7 +26,7 @@ | |||
"php-64bit": ">=7.0", | |||
"pleonasm/merkle-tree": "1.0.0", | |||
"composer/semver": "^1.4.0|^3.2.0", | |||
"lastguest/murmurhash": "v2.0.0", | |||
"lastguest/murmurhash": "v2.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olegabr how do you think ^2.1.0
(they support after 2.1.0)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sc0Vu I prefer the exact version here for better security.
Please merge this :- ) |
For information we maintain a fork to be PHP 8 compatible (https://github.com/ProtonMail/bitcoin-php) |
PHP v8 support requires newer lastguest/murmurhash version